[GitHub] [incubator-pinot] siddharthteotia opened a new pull request #4790: Support ORDER BY for DISTINCT queries

[GitBox <gi...@apache.org>]

siddharthteotia opened a new pull request #4790: Support ORDER BY for DISTINCT queries
URL: https://github.com/apache/incubator-pinot/pull/4790
 
 
   Use IndexedTable for segment level execution. We were already using DistinctTable (a custom object serialized as a single column value). DistinctTable now extends SimpleIndexedTable.
   
   Added ORDER BY queries to existing unit tests
   
   cc @npawar , @mayankshriv , @Jackie-Jiang 
   
   One of the key things identified is that IndexedTable and IndexedTableResizer interface is very strongly coupled with Record level abstraction whereas for DISTINCT (and may be in future for other scenarios), we only need Key part of Record. So currently this forces an extra object construction. I will have a follow-up PR to address this by redesigning some parts of IndexedTable interface or at least provide alternate APIs that work at Key level. This needs some design.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org