You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/01 17:25:35 UTC
[GitHub] [arrow-datafusion] jackwener opened a new pull request, #4464: remove Object-oriented get methods of Filter.
jackwener opened a new pull request, #4464:
URL: https://github.com/apache/arrow-datafusion/pull/4464
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #4464: remove access methods of Filter and make field pub.
Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #4464:
URL: https://github.com/apache/arrow-datafusion/pull/4464#discussion_r1038765446
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1193,9 +1193,9 @@ pub struct SubqueryAlias {
#[derive(Clone)]
pub struct Filter {
/// The predicate expression, which must have Boolean type.
- predicate: Expr,
+ pub predicate: Expr,
Review Comment:
Yes, but I think it isn't a problem.
`Projection` `Aggregate` `Subquery` .... also is like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #4464: remove access methods of Filter and make field pub.
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #4464:
URL: https://github.com/apache/arrow-datafusion/pull/4464#issuecomment-1337955578
What problem is this PR solving? It is partially reverting changes from https://github.com/apache/arrow-datafusion/pull/3796 that were introduced to prevent some class of errors when constructing plans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4464: remove access methods of Filter and make field pub.
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #4464:
URL: https://github.com/apache/arrow-datafusion/pull/4464#discussion_r1038769522
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1193,9 +1193,9 @@ pub struct SubqueryAlias {
#[derive(Clone)]
pub struct Filter {
/// The predicate expression, which must have Boolean type.
- predicate: Expr,
+ pub predicate: Expr,
Review Comment:
Maybe we can at least document what invariants are required between fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #4464: remove access methods of Filter and make field pub.
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #4464:
URL: https://github.com/apache/arrow-datafusion/pull/4464#discussion_r1038759856
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1193,9 +1193,9 @@ pub struct SubqueryAlias {
#[derive(Clone)]
pub struct Filter {
/// The predicate expression, which must have Boolean type.
- predicate: Expr,
+ pub predicate: Expr,
Review Comment:
I think this would allow side-stepping the schema validation in try_new? I don't know how important this is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #4464: remove access methods of Filter and make field pub.
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #4464:
URL: https://github.com/apache/arrow-datafusion/pull/4464#discussion_r1039961568
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1193,9 +1193,9 @@ pub struct SubqueryAlias {
#[derive(Clone)]
pub struct Filter {
/// The predicate expression, which must have Boolean type.
- predicate: Expr,
+ pub predicate: Expr,
Review Comment:
> I think this would allow side-stepping the schema validation in try_new? I don't know how important this is
Yes, the motivation for the current design (introduced in https://github.com/apache/arrow-datafusion/pull/3796) was to prevent invalid filters from being created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener closed pull request #4464: remove access methods of Filter and make field pub.
Posted by GitBox <gi...@apache.org>.
jackwener closed pull request #4464: remove access methods of Filter and make field pub.
URL: https://github.com/apache/arrow-datafusion/pull/4464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #4464: remove access methods of Filter and make field pub.
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #4464:
URL: https://github.com/apache/arrow-datafusion/pull/4464#discussion_r1038759856
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1193,9 +1193,9 @@ pub struct SubqueryAlias {
#[derive(Clone)]
pub struct Filter {
/// The predicate expression, which must have Boolean type.
- predicate: Expr,
+ pub predicate: Expr,
Review Comment:
I think this would allow side-stepping the schema validation in try_new?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #4464: remove access methods of Filter and make field pub.
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #4464:
URL: https://github.com/apache/arrow-datafusion/pull/4464#issuecomment-1338519255
>
Got it, Thanks your explanation @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org