You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2019/09/23 12:22:51 UTC
[GitHub] [incubator-echarts] 100pah commented on a change in pull request
#11302: Feature #7340. Add the itemStyle to legend
100pah commented on a change in pull request #11302: Feature #7340. Add the itemStyle to legend
URL: https://github.com/apache/incubator-echarts/pull/11302#discussion_r327072550
##########
File path: src/visual/dataColor.js
##########
@@ -74,6 +76,23 @@ export default function (seriesType) {
// Set data all color for legend
dataAll.setItemVisual(rawIdx, 'color', singleDataColor);
}
+
+ if (!singleDataBorderColor) {
+ // FIXME Performance
+ var itemModel = dataAll.getItemModel(rawIdx);
Review comment:
itemModel should not be created twice if both `singleDataborderColor` and `singleDataColor` is true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org