You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Richard W. Eggert II (JIRA)" <ji...@apache.org> on 2015/10/27 14:55:27 UTC
[jira] [Comment Edited] (SPARK-9026) SimpleFutureAction.onComplete
should not tie up a separate thread for each callback
[ https://issues.apache.org/jira/browse/SPARK-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976425#comment-14976425 ]
Richard W. Eggert II edited comment on SPARK-9026 at 10/27/15 1:55 PM:
-----------------------------------------------------------------------
Also see https://github.com/apache/spark/pull/9264, which fixes this issue for SimpleFutureAction and also fixes a related issue in ComplexFutureAction.
was (Author: reggert1980):
Also see https://github.com/apache/spark/pull/9264, which fixes this issue for `SimpleFutureAction` and also fixes a related issue in `ComplexFutureAction`.
> SimpleFutureAction.onComplete should not tie up a separate thread for each callback
> -----------------------------------------------------------------------------------
>
> Key: SPARK-9026
> URL: https://issues.apache.org/jira/browse/SPARK-9026
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
> Reporter: Josh Rosen
> Assignee: Josh Rosen
>
> As [~zsxwing] points out at https://github.com/apache/spark/pull/7276#issuecomment-121097747, SimpleFutureAction currently blocks a separate execution context thread for each callback registered via onComplete:
> {code}
> override def onComplete[U](func: (Try[T]) => U)(implicit executor: ExecutionContext) {
> executor.execute(new Runnable {
> override def run() {
> func(awaitResult())
> }
> })
> }
> {code}
> We should fix this so that callbacks do not steal threads.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org