You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by mmucha-redhat <gi...@git.apache.org> on 2018/01/07 20:15:32 UTC

[GitHub] nifi issue #2384: NIFI-4745 : configuration property allowing failure descri...

Github user mmucha-redhat commented on the issue:

    https://github.com/apache/nifi/pull/2384
  
    Hi!
    
    This is my first contribution. Please help me to finish this; I don't like the śtate of code in this file, and would like to agree on doing some refactorings, namely completelyFlowFile having too many arguments. Ideally I wouldn't like to pass attributeNameToStoreFailureDescription into this method, but I did not find a way how to add attribute, when writer is not closed yet. Please comment heavily if needed, I'm here ready to fix all issues!
    Thanks!



---