You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/19 19:44:17 UTC

[GitHub] [airflow] XD-DENG commented on a diff in pull request #28475: Fix flaky test_recover_from_resource_too_old exception

XD-DENG commented on code in PR #28475:
URL: https://github.com/apache/airflow/pull/28475#discussion_r1052576617


##########
tests/executors/test_kubernetes_executor.py:
##########
@@ -1249,12 +1249,13 @@ def effect():
             try:
                 # self.watcher._run() is mocked and return "500" as last resource_version
                 self.watcher.run()
+                assert False, "Should have raised Exception"

Review Comment:
   The change in line 1258 is all good to me.
   But is this change at line 1252 necessary? I don't fully get it yet . The watcher is already mocked and will fail



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org