You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/03/14 18:12:08 UTC

[GitHub] [trafficcontrol] shamrickus opened a new pull request #6651: Run Angular 12/13 migrations for TPv2

shamrickus opened a new pull request #6651:
URL: https://github.com/apache/trafficcontrol/pull/6651

<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:

Closes: #ISSUE
Related: #ISSUE

If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->

This PR runs the migrations that were intended to be ran when upgrading from Angular 11. It also updates some packages.
<hr/>

## Which Traffic Control components are affected by this PR?

- Traffic Portal 2

## What is the best way to verify this PR?
Verify tests pass, production build is correctly optimized/minimized/etc, dev build _is not_ and that theming still works within the app.

Only `package.json` and `.gitignore` were edited manually, `package` for the package updates and `.gitignore` to remove the ignoral of the entire `.angular` folder since it _can_ have project wide config files.

## If this is a bugfix, which Traffic Control versions contained the bug?

## PR submission checklist
- [x] This PR has tests 
- [ ] This PR has documentation 
- [ ] This PR has a CHANGELOG.md entry 
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)

<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #6651: Run Angular 12/13 migrations for TPv2

Posted by GitBox <gi...@apache.org>.

shamrickus commented on a change in pull request #6651:
URL: https://github.com/apache/trafficcontrol/pull/6651#discussion_r840904935



##########
File path: experimental/traffic-portal/.gitignore
##########
@@ -12,7 +12,6 @@
 
 # compiled output
 /dist
-/.angular

Review comment:
       I wanted to match the behavior of a newly generated angular project and it doesn't ignore `.angular`. That having been said I don't mind adding it back since as you said, it doesn't currently do anything.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6651: Run Angular 12/13 migrations for TPv2

Posted by GitBox <gi...@apache.org>.

ocket8888 commented on a change in pull request #6651:
URL: https://github.com/apache/trafficcontrol/pull/6651#discussion_r840913870



##########
File path: experimental/traffic-portal/.gitignore
##########
@@ -12,7 +12,6 @@
 
 # compiled output
 /dist
-/.angular

Review comment:
       I can't fathom why they'd add it like that. `.angular` looks like a directory meant for use by angular, and configuration used by its users is already outside of there so I have no idea why anyone wouldn't just want to ignore the whole thing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6651: Run Angular 12/13 migrations for TPv2

Posted by GitBox <gi...@apache.org>.

ocket8888 commented on a change in pull request #6651:
URL: https://github.com/apache/trafficcontrol/pull/6651#discussion_r840894039



##########
File path: experimental/traffic-portal/.gitignore
##########
@@ -12,7 +12,6 @@
 
 # compiled output
 /dist
-/.angular

Review comment:
       I don't think this should have been changed. As of right now, we don't want anything that's in `.angular`, not just the `cache` subdirectory.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org