[GitHub] [ozone] smengcl commented on a diff in pull request #3678: HDDS-6726. Close RocksObject in Recon and tools

[GitBox <gi...@apache.org>]

smengcl commented on code in PR #3678:
URL: https://github.com/apache/ozone/pull/3678#discussion_r945490868


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHADBTransactionBufferImpl.java:
##########
@@ -138,5 +138,8 @@ public String toString() {
 
   @Override
   public void close() throws IOException {
+    if (currentBatchOperation != null) {
+      currentBatchOperation.close();

Review Comment:
   Can `currentBatchOperation` be safely closed twice without any side effects? If not, does it make sense to set `currentBatchOperation` to `null` here just in case there is a pathological caller where this could be closed twice?
   
   ```suggestion
         currentBatchOperation.close();
         currentBatchOperation = null;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org