You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by pdc <gi...@git.apache.org> on 2015/10/23 18:31:06 UTC

[GitHub] poi pull request: Make client anchors permit row values up to 6553...

GitHub user pdc opened a pull request:

    https://github.com/apache/poi/pull/24

    Make client anchors permit row values up to 65535.

    Previously values over 32767 were treated as negative, error message gives the maximum as 65536 rather than 65535. This meant you got exceptions like the following:
    
        java.lang.IllegalArgumentException: row1 must be between 0 and 65536, but was: -267

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pdc/poi anchor-row-unsigned

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/poi/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit d2f623d65f4441715b0f429d22ab8ee518d3e286
Author: Damian Cugley <pd...@corefiling.com>
Date:   2015-10-23T15:37:00Z

    Make client anchors permit row values up to 65535.
    
    Perviously values over 32767 were treated as negative,
    and the maximum was set to 65280.

commit 315502560ccd8202ce2abd37a3ccfeb9a55c02cf
Author: Damian Cugley <pd...@corefiling.com>
Date:   2015-10-23T16:29:53Z

    Change setRow1 and setRow2 to enforce the same maximums as the constructor

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[GitHub] poi pull request: Make client anchors permit row values up to 6553...

Posted by pdc <gi...@git.apache.org>.
Github user pdc closed the pull request at:

    https://github.com/apache/poi/pull/24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org