You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Kalyani Kashikar <ka...@freestoneinfotech.com> on 2017/04/11 09:53:39 UTC
Review Request 58336: ATLAS-1433: Atlas allows creation of tag with
attributes' name same as that of its parent tags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58336/
-----------------------------------------------------------
Review request for atlas, keval bhatt and Madhan Neethiraj.
Bugs: ATLAS-1433
https://issues.apache.org/jira/browse/ATLAS-1433
Repository: atlas
Description
-------
Patch contains following features:
* While adding attributes to the tag, duplicate attributes has been restricted, and its prompted accordingly.
* If tag contain supertype, it displays on detail page under 'Derived From:' label. If superType is empty, label gets hidden.
Diffs
-----
dashboardv2/public/css/scss/tag.scss 6c2d29a
dashboardv2/public/js/models/VTag.js 51b53d1
dashboardv2/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html 2cb0fc9
dashboardv2/public/js/utils/CommonViewFunction.js 615bef4
dashboardv2/public/js/views/tag/TagAttributeDetailLayoutView.js ecf32f2
dashboardv2/public/js/views/tag/TagLayoutView.js 8591100
Diff: https://reviews.apache.org/r/58336/diff/1/
Testing
-------
Test following scenarios:
* Verified while adding attributes to the tag, duplicate attributes are restricted.
* Verified when adding the attribute to the tag and if its already present in the parent tag then attributes are restricted.
* Verified when tag contain supertype, it displayed on detail page under 'Derived From:' label. If superType is empty, label gets hidden.
Thanks,
Kalyani Kashikar
Re: Review Request 58336: ATLAS-1433: Atlas allows creation of tag
with attributes' name same as that of its parent tags.
Posted by Kalyani Kashikar <ka...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58336/
-----------------------------------------------------------
(Updated April 11, 2017, 1:30 p.m.)
Review request for atlas, keval bhatt and Madhan Neethiraj.
Changes
-------
Removed commomViewFunction.js file from patch.
Bugs: ATLAS-1433
https://issues.apache.org/jira/browse/ATLAS-1433
Repository: atlas
Description
-------
Patch contains following features:
* While adding attributes to the tag, duplicate attributes has been restricted, and its prompted accordingly.
* If tag contain supertype, it displays on detail page under 'Derived From:' label. If superType is empty, label gets hidden.
Diffs (updated)
-----
dashboardv2/public/css/scss/graph.scss feb9c10
dashboardv2/public/css/scss/tag.scss 6c2d29a
dashboardv2/public/js/models/VTag.js 51b53d1
dashboardv2/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html 2cb0fc9
dashboardv2/public/js/views/tag/TagAttributeDetailLayoutView.js ecf32f2
dashboardv2/public/js/views/tag/TagLayoutView.js 8591100
Diff: https://reviews.apache.org/r/58336/diff/2/
Changes: https://reviews.apache.org/r/58336/diff/1-2/
Testing
-------
Test following scenarios:
* Verified while adding attributes to the tag, duplicate attributes are restricted.
* Verified when adding the attribute to the tag and if its already present in the parent tag then attributes are restricted.
* Verified when tag contain supertype, it displayed on detail page under 'Derived From:' label. If superType is empty, label gets hidden.
Thanks,
Kalyani Kashikar