You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Fatorin (via GitHub)" <gi...@apache.org> on 2026/08/25 05:52:14 UTC
[PR] feat(bindings/dotnet): support conditional delete with if-match [opendal]
Fatorin opened a new pull request, #8137:
URL: https://github.com/apache/opendal/pull/8137
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
N/A
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
[#7607](https://github.com/Fatorin/opendal/issues/7607) added conditional delete with If-Match to core and services/s3, but the .NET binding was left with if_match hardcoded to None in parse_delete_options, so the option was unreachable from C#.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Parse `if_match` from the native options map, expose it as `DeleteOptions.IfMatch`, and add the corresponding `delete_with_if_match` field to the FFI capability struct and `Capability.DeleteWithIfMatch`.
Two behavior tests cover the matching and the mismatching case, verified against AWS S3.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking-changes` label.
-->
`DeleteOptions.IfMatch` and `Capability.DeleteWithIfMatch` are new.
Nothing is removed or renamed, so there are no breaking changes.
# AI Usage Statement
<!--
If AI materially assisted this PR, briefly describe its role and disclose any
assumptions or unknowns that affect review. Do not include routine command output
or repeat information provided elsewhere.
The author remains responsible for every submitted claim and change. If AI did
not materially assist this PR, write "None".
-->
AI reviewed the diff and the new tests, and helped confirm which S3 implementations actually honour If-Match on DeleteObject. All code was written by hand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bindings/dotnet): support conditional delete with if-match [opendal]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #8137:
URL: https://github.com/apache/opendal/pull/8137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org