You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/04/26 10:01:05 UTC
svn commit: r1877016 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java
Author: tilman
Date: Sun Apr 26 10:01:05 2020
New Revision: 1877016
URL: http://svn.apache.org/viewvc?rev=1877016&view=rev
Log:
PDFBOX-4819: fix OCMD handling, each case is unique now; add comments
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java?rev=1877016&r1=1877015&r2=1877016&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java Sun Apr 26 10:01:05 2020
@@ -1847,17 +1847,19 @@ public class PageDrawer extends PDFGraph
visibles.add(!isHiddenOCG(prop));
}
COSName visibilityPolicy = ocmd.getVisibilityPolicy();
+ // visible if any of the entries in OCGs are OFF
if (COSName.ANY_OFF.equals(visibilityPolicy))
{
for (boolean visible : visibles)
{
if (!visible)
{
- return true;
+ return false;
}
}
- return false;
+ return true;
}
+ // visible only if all of the entries in OCGs are ON
if (COSName.ALL_ON.equals(visibilityPolicy))
{
for (boolean visible : visibles)
@@ -1869,17 +1871,19 @@ public class PageDrawer extends PDFGraph
}
return false;
}
+ // visible only if all of the entries in OCGs are OFF
if (COSName.ALL_OFF.equals(visibilityPolicy))
{
for (boolean visible : visibles)
{
if (visible)
{
- return false;
+ return true;
}
}
- return true;
+ return false;
}
+ // visible if any of the entries in OCGs are ON
// AnyOn is default
for (boolean visible : visibles)
{