[GitHub] [nifi] mcgilman edited a comment on issue #3440: NIFI-6221 Adding 'Download' and 'View' content buttons to List Queue

[GitBox <gi...@apache.org>]

mcgilman edited a comment on issue #3440: NIFI-6221 Adding 'Download' and 'View' content buttons to List Queue
URL: https://github.com/apache/nifi/pull/3440#issuecomment-485468028
 
 
   @patricker @aeaversa Sorry wasn't able to review this PR earlier. I have been traveling. If I recall correctly, the provenance details should only be providing access to the content if allowed. There should be a check server side [1] that will populate the content claim details if the user has the appropriate permissions and then will provide the user with the available actions [2].
   
   I haven't had a chance to try this out yet. Does this PR make the View and Download buttons always available? If so, we probably need to reopen this and address that. The users should only be presented with the available actions for them. Otherwise, they will never know which actions will actually work successfully.
   
   [1] https://github.com/apache/nifi/blob/94c2b1e76ebab33b6417fb46ce046e59c51fcdca/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java#L1466
   [2] https://github.com/apache/nifi/blob/94c2b1e76ebab33b6417fb46ce046e59c51fcdca/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/provenance/nf-provenance-table.js#L1493

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services