You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2011/06/28 14:48:17 UTC
[jira] [Created] (CASSANDRA-2835) CFMetadata don't set the default
for Replicate_on_write correctly
CFMetadata don't set the default for Replicate_on_write correctly
------------------------------------------------------------------
Key: CASSANDRA-2835
URL: https://issues.apache.org/jira/browse/CASSANDRA-2835
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 0.8.0
Reporter: Sylvain Lebresne
Assignee: Sylvain Lebresne
Fix For: 0.8.2
Attachments: 2835.patch
Replicate_on_write *must* default to true (defaulting to false is very dangerous and imho, the option of setting it to false shouldn't exist in the first place) and CFMetadata.DEFAULT_REPLICATE_ON_WRITE is correctly true. But it doesn't get set correctly. Instead, the code force the value of the cf_def even if it wasn't defined, resulting in setting it to false since that is the default value for a boolean in JAVA.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2835) CFMetadata don't set the
default for Replicate_on_write correctly
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056493#comment-13056493 ]
Sylvain Lebresne commented on CASSANDRA-2835:
---------------------------------------------
Committed, thanks (I've included a not in the NEWS file as well as updated the wiki).
> CFMetadata don't set the default for Replicate_on_write correctly
> ------------------------------------------------------------------
>
> Key: CASSANDRA-2835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2835
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.8.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Labels: counters
> Fix For: 0.8.2
>
> Attachments: 2835.patch
>
>
> Replicate_on_write *must* default to true (defaulting to false is very dangerous and imho, the option of setting it to false shouldn't exist in the first place) and CFMetadata.DEFAULT_REPLICATE_ON_WRITE is correctly true. But it doesn't get set correctly. Instead, the code force the value of the cf_def even if it wasn't defined, resulting in setting it to false since that is the default value for a boolean in JAVA.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2835) CFMetadata don't set the default
for Replicate_on_write correctly
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-2835:
----------------------------------------
Attachment: 2835.patch
> CFMetadata don't set the default for Replicate_on_write correctly
> ------------------------------------------------------------------
>
> Key: CASSANDRA-2835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2835
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.8.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Labels: counters
> Fix For: 0.8.2
>
> Attachments: 2835.patch
>
>
> Replicate_on_write *must* default to true (defaulting to false is very dangerous and imho, the option of setting it to false shouldn't exist in the first place) and CFMetadata.DEFAULT_REPLICATE_ON_WRITE is correctly true. But it doesn't get set correctly. Instead, the code force the value of the cf_def even if it wasn't defined, resulting in setting it to false since that is the default value for a boolean in JAVA.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2835) CFMetadata don't set the
default for Replicate_on_write correctly
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056798#comment-13056798 ]
Hudson commented on CASSANDRA-2835:
-----------------------------------
Integrated in Cassandra-0.8 #197 (See [https://builds.apache.org/job/Cassandra-0.8/197/])
> CFMetadata don't set the default for Replicate_on_write correctly
> ------------------------------------------------------------------
>
> Key: CASSANDRA-2835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2835
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.8.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Labels: counters
> Fix For: 0.8.2
>
> Attachments: 2835.patch
>
>
> Replicate_on_write *must* default to true (defaulting to false is very dangerous and imho, the option of setting it to false shouldn't exist in the first place) and CFMetadata.DEFAULT_REPLICATE_ON_WRITE is correctly true. But it doesn't get set correctly. Instead, the code force the value of the cf_def even if it wasn't defined, resulting in setting it to false since that is the default value for a boolean in JAVA.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2835) CFMetadata don't set the
default for Replicate_on_write correctly
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056476#comment-13056476 ]
Jonathan Ellis commented on CASSANDRA-2835:
-------------------------------------------
Add a note to NEWS suggesting checking counter settings on upgrade?
> CFMetadata don't set the default for Replicate_on_write correctly
> ------------------------------------------------------------------
>
> Key: CASSANDRA-2835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2835
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.8.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Labels: counters
> Fix For: 0.8.2
>
> Attachments: 2835.patch
>
>
> Replicate_on_write *must* default to true (defaulting to false is very dangerous and imho, the option of setting it to false shouldn't exist in the first place) and CFMetadata.DEFAULT_REPLICATE_ON_WRITE is correctly true. But it doesn't get set correctly. Instead, the code force the value of the cf_def even if it wasn't defined, resulting in setting it to false since that is the default value for a boolean in JAVA.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2835) CFMetadata don't set the
default for Replicate_on_write correctly
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056475#comment-13056475 ]
Jonathan Ellis commented on CASSANDRA-2835:
-------------------------------------------
+1
> CFMetadata don't set the default for Replicate_on_write correctly
> ------------------------------------------------------------------
>
> Key: CASSANDRA-2835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2835
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.8.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Labels: counters
> Fix For: 0.8.2
>
> Attachments: 2835.patch
>
>
> Replicate_on_write *must* default to true (defaulting to false is very dangerous and imho, the option of setting it to false shouldn't exist in the first place) and CFMetadata.DEFAULT_REPLICATE_ON_WRITE is correctly true. But it doesn't get set correctly. Instead, the code force the value of the cf_def even if it wasn't defined, resulting in setting it to false since that is the default value for a boolean in JAVA.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira