You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sdedic (via GitHub)" <gi...@apache.org> on 2025/01/09 15:35:41 UTC
[PR] Fix race/error handling issues on NBLS restart. [netbeans]
sdedic opened a new pull request, #8134:
URL: https://github.com/apache/netbeans/pull/8134
During testing, it turned out that when NBLS is enabled "fast enough" after extension start, the extension may not initialize properly.
There are surely more bugs ;)) but the ones most prominent are:
- there was a missing catch() after stopClient() call
- reject() on kill promise was called **before** kill actually completed
- testAdapter was not re-initialized (and re-loaded with data) each time client restarts
In addition, if the client is stop()ped during/soon after restart, the Explorer (project view, database view or cloud assets) attemp to communicate with a dead client, which results in error notifications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix race/error handling issues on NBLS restart. [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic merged PR #8134:
URL: https://github.com/apache/netbeans/pull/8134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix race/error handling issues on NBLS restart. [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #8134:
URL: https://github.com/apache/netbeans/pull/8134#issuecomment-2591893118
Squashed before commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix race/error handling issues on NBLS restart. [netbeans]
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #8134:
URL: https://github.com/apache/netbeans/pull/8134#issuecomment-2582416075
During further testing it occurred that the request to restart NBLS because of change `enableJava` flag was fired before the logs were received and `activationPending` was re-set .... so the request to restart NBLS was ignored. It seems that the ancient "collision avoidance" is now fully obsolete by waiting on the `client` promise for stop().
I've removed the simple avoidance flag - but needed to slightly change code so that closed server will not respawn itself if another one is already starting.
Please review carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists