You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/03 02:43:10 UTC
[GitHub] [shardingsphere] weiyue888999 opened a new pull request #10246: fix example pom miss shardingsphere-read-write-splitting-api dependency
weiyue888999 opened a new pull request #10246:
URL: https://github.com/apache/shardingsphere/pull/10246
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
解决example模块下，缺乏shardingsphere-read-write-splitting-api依赖的问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] weiyue888999 closed pull request #10246: fix example pom miss shardingsphere-read-write-splitting-api dependency
Posted by GitBox <gi...@apache.org>.
weiyue888999 closed pull request #10246:
URL: https://github.com/apache/shardingsphere/pull/10246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #10246: fix example pom miss shardingsphere-read-write-splitting-api dependency
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #10246:
URL: https://github.com/apache/shardingsphere/pull/10246#discussion_r624865069
##########
File path: examples/pom.xml
##########
@@ -167,6 +167,11 @@
<artifactId>shardingsphere-infra-common</artifactId>
<version>${shardingsphere.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.shardingsphere</groupId>
+ <artifactId>shardingsphere-read-write-splitting-api</artifactId>
Review comment:
The `shardingsphere-read-write-splitting-api` has already change to `shardingsphere-readwrite-splitting-api`, please update it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] weiyue888999 commented on a change in pull request #10246: fix example pom miss shardingsphere-read-write-splitting-api dependency
Posted by GitBox <gi...@apache.org>.
weiyue888999 commented on a change in pull request #10246:
URL: https://github.com/apache/shardingsphere/pull/10246#discussion_r624874420
##########
File path: examples/pom.xml
##########
@@ -167,6 +167,11 @@
<artifactId>shardingsphere-infra-common</artifactId>
<version>${shardingsphere.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.shardingsphere</groupId>
+ <artifactId>shardingsphere-read-write-splitting-api</artifactId>
Review comment:
oh , oh , my fault .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #10246: fix example pom miss shardingsphere-read-write-splitting-api dependency
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10246:
URL: https://github.com/apache/shardingsphere/pull/10246#issuecomment-830999831
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10246](https://codecov.io/gh/apache/shardingsphere/pull/10246?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30c90dc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/11320534213183e9716cd867c4d4b3fda02ef4f4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1132053) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/10246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #10246 +/- ##
=========================================
Coverage 67.96% 67.96%
Complexity 683 683
=========================================
Files 1703 1703
Lines 29201 29201
Branches 5250 5250
=========================================
Hits 19845 19845
Misses 7826 7826
Partials 1530 1530
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10246?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10246?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1132053...30c90dc](https://codecov.io/gh/apache/shardingsphere/pull/10246?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org