You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Daniel Dai (JIRA)" <ji...@apache.org> on 2010/04/26 20:00:35 UTC

[jira] Created: (PIG-1394) POCombinerPackage hold too much memory for InternalCachedBag

POCombinerPackage hold too much memory for InternalCachedBag
------------------------------------------------------------

                 Key: PIG-1394
                 URL: https://issues.apache.org/jira/browse/PIG-1394
             Project: Pig
          Issue Type: Bug
          Components: impl
    Affects Versions: 0.7.0
            Reporter: Daniel Dai
            Assignee: Daniel Dai
             Fix For: 0.8.0
         Attachments: PIG-1394-1.patch

In POCombinerPackage, we create bunch of InternalCachedBag, the number of which is the number of algebraic UDFs we use. However, when we create InternalCachedBag, we use the default construct which assume we only create 1 InternalCachedBag in the system. It turns out we reserve way to much memory to InternalCachedBag.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (PIG-1394) POCombinerPackage hold too much memory for InternalCachedBag

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai closed PIG-1394.
---------------------------


> POCombinerPackage hold too much memory for InternalCachedBag
> ------------------------------------------------------------
>
>                 Key: PIG-1394
>                 URL: https://issues.apache.org/jira/browse/PIG-1394
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.7.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.7.0
>
>         Attachments: PIG-1394-1.patch, PIG-1394-2.patch
>
>
> In POCombinerPackage, we create bunch of InternalCachedBag, the number of which is the number of algebraic UDFs we use. However, when we create InternalCachedBag, we use the default construct which assume we only create 1 InternalCachedBag in the system. It turns out we reserve way to much memory to InternalCachedBag.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1394) POCombinerPackage hold too much memory for InternalCachedBag

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1394:
----------------------------

    Status: Patch Available  (was: Open)

> POCombinerPackage hold too much memory for InternalCachedBag
> ------------------------------------------------------------
>
>                 Key: PIG-1394
>                 URL: https://issues.apache.org/jira/browse/PIG-1394
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.7.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1394-1.patch
>
>
> In POCombinerPackage, we create bunch of InternalCachedBag, the number of which is the number of algebraic UDFs we use. However, when we create InternalCachedBag, we use the default construct which assume we only create 1 InternalCachedBag in the system. It turns out we reserve way to much memory to InternalCachedBag.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1394) POCombinerPackage hold too much memory for InternalCachedBag

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1394:
----------------------------

    Fix Version/s: 0.7.0
                       (was: 0.8.0)

> POCombinerPackage hold too much memory for InternalCachedBag
> ------------------------------------------------------------
>
>                 Key: PIG-1394
>                 URL: https://issues.apache.org/jira/browse/PIG-1394
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.7.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.7.0
>
>         Attachments: PIG-1394-1.patch, PIG-1394-2.patch
>
>
> In POCombinerPackage, we create bunch of InternalCachedBag, the number of which is the number of algebraic UDFs we use. However, when we create InternalCachedBag, we use the default construct which assume we only create 1 InternalCachedBag in the system. It turns out we reserve way to much memory to InternalCachedBag.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1394) POCombinerPackage hold too much memory for InternalCachedBag

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862430#action_12862430 ] 

Pradeep Kamath commented on PIG-1394:
-------------------------------------

+1

> POCombinerPackage hold too much memory for InternalCachedBag
> ------------------------------------------------------------
>
>                 Key: PIG-1394
>                 URL: https://issues.apache.org/jira/browse/PIG-1394
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.7.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.7.0
>
>         Attachments: PIG-1394-1.patch, PIG-1394-2.patch
>
>
> In POCombinerPackage, we create bunch of InternalCachedBag, the number of which is the number of algebraic UDFs we use. However, when we create InternalCachedBag, we use the default construct which assume we only create 1 InternalCachedBag in the system. It turns out we reserve way to much memory to InternalCachedBag.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1394) POCombinerPackage hold too much memory for InternalCachedBag

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861158#action_12861158 ] 

Hadoop QA commented on PIG-1394:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12442875/PIG-1394-1.patch
  against trunk revision 937570.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/303/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/303/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/303/console

This message is automatically generated.

> POCombinerPackage hold too much memory for InternalCachedBag
> ------------------------------------------------------------
>
>                 Key: PIG-1394
>                 URL: https://issues.apache.org/jira/browse/PIG-1394
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.7.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.7.0
>
>         Attachments: PIG-1394-1.patch, PIG-1394-2.patch
>
>
> In POCombinerPackage, we create bunch of InternalCachedBag, the number of which is the number of algebraic UDFs we use. However, when we create InternalCachedBag, we use the default construct which assume we only create 1 InternalCachedBag in the system. It turns out we reserve way to much memory to InternalCachedBag.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1394) POCombinerPackage hold too much memory for InternalCachedBag

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1394:
----------------------------

    Attachment: PIG-1394-1.patch

> POCombinerPackage hold too much memory for InternalCachedBag
> ------------------------------------------------------------
>
>                 Key: PIG-1394
>                 URL: https://issues.apache.org/jira/browse/PIG-1394
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.7.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1394-1.patch
>
>
> In POCombinerPackage, we create bunch of InternalCachedBag, the number of which is the number of algebraic UDFs we use. However, when we create InternalCachedBag, we use the default construct which assume we only create 1 InternalCachedBag in the system. It turns out we reserve way to much memory to InternalCachedBag.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1394) POCombinerPackage hold too much memory for InternalCachedBag

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1394:
----------------------------

    Attachment: PIG-1394-2.patch

> POCombinerPackage hold too much memory for InternalCachedBag
> ------------------------------------------------------------
>
>                 Key: PIG-1394
>                 URL: https://issues.apache.org/jira/browse/PIG-1394
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.7.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1394-1.patch, PIG-1394-2.patch
>
>
> In POCombinerPackage, we create bunch of InternalCachedBag, the number of which is the number of algebraic UDFs we use. However, when we create InternalCachedBag, we use the default construct which assume we only create 1 InternalCachedBag in the system. It turns out we reserve way to much memory to InternalCachedBag.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1394) POCombinerPackage hold too much memory for InternalCachedBag

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1394:
----------------------------

    Attachment: PIG-1394-2.patch

Previous patch miss something, attach a new one.

> POCombinerPackage hold too much memory for InternalCachedBag
> ------------------------------------------------------------
>
>                 Key: PIG-1394
>                 URL: https://issues.apache.org/jira/browse/PIG-1394
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.7.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1394-1.patch, PIG-1394-2.patch
>
>
> In POCombinerPackage, we create bunch of InternalCachedBag, the number of which is the number of algebraic UDFs we use. However, when we create InternalCachedBag, we use the default construct which assume we only create 1 InternalCachedBag in the system. It turns out we reserve way to much memory to InternalCachedBag.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1394) POCombinerPackage hold too much memory for InternalCachedBag

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1394:
----------------------------

          Status: Resolved  (was: Patch Available)
    Hadoop Flags: [Reviewed]
      Resolution: Fixed

Committed to both 0.7 branch and trunk.

> POCombinerPackage hold too much memory for InternalCachedBag
> ------------------------------------------------------------
>
>                 Key: PIG-1394
>                 URL: https://issues.apache.org/jira/browse/PIG-1394
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.7.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.7.0
>
>         Attachments: PIG-1394-1.patch, PIG-1394-2.patch
>
>
> In POCombinerPackage, we create bunch of InternalCachedBag, the number of which is the number of algebraic UDFs we use. However, when we create InternalCachedBag, we use the default construct which assume we only create 1 InternalCachedBag in the system. It turns out we reserve way to much memory to InternalCachedBag.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1394) POCombinerPackage hold too much memory for InternalCachedBag

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1394:
----------------------------

    Attachment:     (was: PIG-1394-2.patch)

> POCombinerPackage hold too much memory for InternalCachedBag
> ------------------------------------------------------------
>
>                 Key: PIG-1394
>                 URL: https://issues.apache.org/jira/browse/PIG-1394
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.7.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.8.0
>
>         Attachments: PIG-1394-1.patch
>
>
> In POCombinerPackage, we create bunch of InternalCachedBag, the number of which is the number of algebraic UDFs we use. However, when we create InternalCachedBag, we use the default construct which assume we only create 1 InternalCachedBag in the system. It turns out we reserve way to much memory to InternalCachedBag.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.