You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by mmiklavc <gi...@git.apache.org> on 2017/10/04 15:04:32 UTC
[GitHub] metron pull request #783: METRON-1228: Configuration Management PUSH immedia...
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/783
METRON-1228: Configuration Management PUSH immediately does DUMP after
Addresses https://issues.apache.org/jira/browse/METRON-1228
## Contributor Comments
Missing 'break' is causing pushes to immediately dump configs to std output.
To test, perform a zk_load_configs.sh -m PUSH command and verify that the command is not followed with a screen dump of the zk configs.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron METRON-1228
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/783.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #783
----
commit 6b2f5eadd3e27a49d94d7e1483271caf74630abd
Author: Michael Miklavcic <mi...@gmail.com>
Date: 2017-10-04T14:59:14Z
METRON-1228: Configuration Management PUSH immediately does DUMP after
----
---
[GitHub] metron pull request #783: METRON-1228: Configuration Management PUSH immedia...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/783
---
[GitHub] metron issue #783: METRON-1228: Configuration Management PUSH immediately do...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/783
+1
---
[GitHub] metron issue #783: METRON-1228: Configuration Management PUSH immediately do...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/783
+1 this has been pissing me off for days
---