You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/13 00:10:19 UTC

[GitHub] [beam] apilloud commented on a change in pull request #14222: [BEAM-10943] Add builtin functions in the Calcite planner.

apilloud commented on a change in pull request #14222:
URL: https://github.com/apache/beam/pull/14222#discussion_r593521481



##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/CalciteQueryPlanner.java
##########
@@ -92,8 +95,20 @@ public CalciteQueryPlanner(JdbcConnection connection, Collection<RuleSet> ruleSe
         @Override
         public QueryPlanner createPlanner(
             JdbcConnection jdbcConnection, Collection<RuleSet> ruleSets) {
+          loadBuiltinFunctions(jdbcConnection);

Review comment:
       I don't see anything like this for ZetaSQL... How do those built in functions get loaded into jdbcConnection?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org