You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by GitBox <gi...@apache.org> on 2020/09/11 13:00:58 UTC
[GitHub] [syncope] DimaAy opened a new pull request #215: [SYNCOPE-1588] Consent Policy
DimaAy opened a new pull request #215:
URL: https://github.com/apache/syncope/pull/215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] ilgrosso commented on a change in pull request #215: [SYNCOPE-1588] Consent Policy
Posted by GitBox <gi...@apache.org>.
ilgrosso commented on a change in pull request #215:
URL: https://github.com/apache/syncope/pull/215#discussion_r487823095
##########
File path: common/am/lib/src/main/java/org/apache/syncope/common/lib/policy/AllowedAttrReleasePolicyConf.java
##########
@@ -29,9 +34,63 @@
* Specify the list of allowed attribute to release.
* Use the special {@code *} to release everything.
*/
+ @JacksonXmlElementWrapper(localName = "allowedAttrs")
+ @JacksonXmlProperty(localName = "allowedAttrs")
+ @JsonProperty("allowedAttrs")
private final List<String> allowedAttrs = new ArrayList<>();
+ private ConsentPolicy consentPolicy;
+
public List<String> getAllowedAttrs() {
return allowedAttrs;
}
+
+ public ConsentPolicy getConsentPolicy() {
+ return consentPolicy;
+ }
+
+ public void setConsentPolicy(final ConsentPolicy consentPolicy) {
+ this.consentPolicy = consentPolicy;
+ }
+
+ public class ConsentPolicy {
Review comment:
Make this class implement at least `Serializable`
##########
File path: wa/starter/src/main/java/org/apache/syncope/wa/starter/config/SyncopeWAConfiguration.java
##########
@@ -148,7 +148,7 @@ public RegisteredServiceMapper registeredServiceMapper() {
attrReleasePolicyConfMappers.put(attrReleaseMapFor.attrReleasePolicyConfClass().getName(), bean);
}
});
-
+
Review comment:
Please revert this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] DimaAy merged pull request #215: [SYNCOPE-1588] Consent Policy
Posted by GitBox <gi...@apache.org>.
DimaAy merged pull request #215:
URL: https://github.com/apache/syncope/pull/215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org