You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/01/23 11:44:52 UTC
[GitHub] qiuchenjian commented on a change in pull request #3096: [WIP]Fixed
Range Sort OOM Issue
qiuchenjian commented on a change in pull request #3096: [WIP]Fixed Range Sort OOM Issue
URL: https://github.com/apache/carbondata/pull/3096#discussion_r250160243
##########
File path: core/src/main/java/org/apache/carbondata/core/memory/IntPointerBuffer.java
##########
@@ -75,17 +75,17 @@ public int get(int rowId) {
}
public void loadToUnsafe() {
- try {
- pointerMemoryBlock =
- UnsafeSortMemoryManager.allocateMemoryWithRetry(this.taskId, pointerBlock.length * 4);
+ pointerMemoryBlock =
+ UnsafeSortMemoryManager.INSTANCE.allocateMemory(this.taskId, pointerBlock.length * 4);
+ // pointerMemoryBlock it means sort storage memory manager does not have space to loaf pointer
+ // buffer in that case use pointerBlock
+ if (null != pointerMemoryBlock) {
Review comment:
better to add a log when pointerMemoryBlock == null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services