You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Nick Bailey (JIRA)" <ji...@apache.org> on 2011/04/14 21:34:05 UTC

[jira] [Created] (CASSANDRA-2482) Make compaction type an enum

Make compaction type an enum
----------------------------

                 Key: CASSANDRA-2482
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2482
             Project: Cassandra
          Issue Type: Bug
    Affects Versions: 0.8
            Reporter: Nick Bailey
            Assignee: Nick Bailey
            Priority: Trivial
             Fix For: 0.8


Compaction type should be an enum, half of the places we set it we use it as a message and include the keyspace/cf although that is already included in the compaction info object.

I realize this is minor and a pedantic but from the standpoint of someone writing a monitoring application its kind of annoying.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-2482) Make compaction type an enum

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020042#comment-13020042 ] 

Jonathan Ellis commented on CASSANDRA-2482:
-------------------------------------------

committed with a couple fixes:

 - row cache save uses correct enum
 - CompactionInfo.getTaskType returns enum instead of string so callers don't have to do string inspection anymore

> Make compaction type an enum
> ----------------------------
>
>                 Key: CASSANDRA-2482
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2482
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Nick Bailey
>            Assignee: Nick Bailey
>            Priority: Trivial
>             Fix For: 0.8
>
>         Attachments: 0001-Make-compactiontype-an-enum.patch
>
>
> Compaction type should be an enum, half of the places we set it we use it as a message and include the keyspace/cf although that is already included in the compaction info object.
> I realize this is minor and a pedantic but from the standpoint of someone writing a monitoring application its kind of annoying.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-2482) Make compaction type an enum

Posted by "Nick Bailey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nick Bailey updated CASSANDRA-2482:
-----------------------------------

    Attachment: 0001-Make-compactiontype-an-enum.patch

> Make compaction type an enum
> ----------------------------
>
>                 Key: CASSANDRA-2482
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2482
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Nick Bailey
>            Assignee: Nick Bailey
>            Priority: Trivial
>             Fix For: 0.8
>
>         Attachments: 0001-Make-compactiontype-an-enum.patch
>
>
> Compaction type should be an enum, half of the places we set it we use it as a message and include the keyspace/cf although that is already included in the compaction info object.
> I realize this is minor and a pedantic but from the standpoint of someone writing a monitoring application its kind of annoying.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-2482) Make compaction type an enum

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020064#comment-13020064 ] 

Hudson commented on CASSANDRA-2482:
-----------------------------------

Integrated in Cassandra-0.8 #7 (See [https://hudson.apache.org/hudson/job/Cassandra-0.8/7/])
    madeCompactionInfo.getTaskType return an enum
patch by nickmbailey; reviewed by jbellis for CASSANDRA-2482


> Make compaction type an enum
> ----------------------------
>
>                 Key: CASSANDRA-2482
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2482
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Nick Bailey
>            Assignee: Nick Bailey
>            Priority: Trivial
>             Fix For: 0.8
>
>         Attachments: 0001-Make-compactiontype-an-enum.patch
>
>
> Compaction type should be an enum, half of the places we set it we use it as a message and include the keyspace/cf although that is already included in the compaction info object.
> I realize this is minor and a pedantic but from the standpoint of someone writing a monitoring application its kind of annoying.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira