[jira] [Commented] (TEZ-3650) Improve performance of FetchStatsLogger#logIndividualFetchComplete

["TezQA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898848#comment-15898848 ] 

TezQA commented on TEZ-3650:
----------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12856433/TEZ-3650.1.patch
  against master revision e84231e.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/2305//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2305//console

This message is automatically generated.

> Improve performance of FetchStatsLogger#logIndividualFetchComplete
> ------------------------------------------------------------------
>
>                 Key: TEZ-3650
>                 URL: https://issues.apache.org/jira/browse/TEZ-3650
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: TEZ-3650.1.patch
>
>
> The cost of logging the fetch completed statement is dominated by two main factors 1) Formatting the download rate and 2) Minor String concatenation that isn't getting optimized.
> In this jira I propose a new Formatter that is optimized by implementing the StringBuilder#append(long) algorithm, but allows for formatting and reuse of StringBuilder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)