[GitHub] spark pull request: [SPARK-12941][SQL][BRANCH-1.4] Spark-SQL JDBC ...

[thomastechs <gi...@git.apache.org>]

Github user thomastechs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10912#discussion_r54525699
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala ---
    @@ -445,4 +445,9 @@ class JDBCSuite extends SparkFunSuite with BeforeAndAfter {
         assert(agg.getCatalystType(1, "", 1, null) == Some(StringType))
       }
     
    +  test("OracleDialect type mapping") {
    +    val oracleDialect = JdbcDialects.get("jdbc:oracle://127.0.0.1/db")
    +    assert(oracleDialect.getJDBCType(StringType).
    +      map(_.databaseTypeDefinition).get == "VARCHAR2(255)")
    +  }
    --- End diff --
    
    Okei @yhuai    So I shall submit another PR, for the same JIRA with the updates in the JDBCSuite.scala in the master branch. I shall also close this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org