You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by dnwe <gi...@git.apache.org> on 2015/03/30 13:49:01 UTC
[GitHub] qpid-proton pull request: NO-JIRA: export.sh creates pax-based tar
GitHub user dnwe opened a pull request:
https://github.com/apache/qpid-proton/pull/14
NO-JIRA: export.sh creates pax-based tar
Having switched to using git-archive, we end up creating a tar that uses
the PAX-based scheme for supporting long pathnames. This causes issues
for a number of extraction tools (ant, 7-zip, etc.) which only support
the GNU tar format. We should stick with GNU tar, as used for previous
qpid-proton releases.
Also update the script to revert to using a suffix of .tar.gz (rather
than .tgz) for the source distribution.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dnwe/qpid-proton fix-export-tar-creation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit ac05f1969efb796d8e7f5ac33d4e5e5bdea501cd
Author: Dominic Evans <do...@uk.ibm.com>
Date: 2015-03-30T11:44:16Z
NO-JIRA: export.sh creates pax-based tar
Having switched to using git-archive, we end up creating a tar that uses
the PAX-based scheme for supporting long pathnames. This causes issues
for a number of extraction tools (ant, 7-zip, etc.) which only support
the GNU tar format. We should stick with GNU tar, as used for previous
qpid-proton releases.
Also update the script to revert to using a suffix of .tar.gz (rather
than .tgz) for the source distribution.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: export.sh creates pax-based tar
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the pull request:
https://github.com/apache/qpid-proton/pull/14#issuecomment-87687689
Ah, I actually missed the note about changing the filename entirely :)
Given that it wouldnt clash as I thought and would actually restore the filename to its historical convention it might actually be helpful to post it for 0.9, though it could be confusing to some people seeing both in the same dir.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: export.sh creates pax-based tar
Posted by rhs <gi...@git.apache.org>.
Github user rhs commented on the pull request:
https://github.com/apache/qpid-proton/pull/14#issuecomment-87651630
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: export.sh creates pax-based tar
Posted by rhs <gi...@git.apache.org>.
Github user rhs commented on the pull request:
https://github.com/apache/qpid-proton/pull/14#issuecomment-88009935
FYI I've added the updated tarballs for 0.9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: export.sh creates pax-based tar
Posted by dnwe <gi...@git.apache.org>.
Github user dnwe commented on the pull request:
https://github.com/apache/qpid-proton/pull/14#issuecomment-87685628
*technically* we wouldn't have a name clash because of the .tgz --> .tar.gz renaming, so people would only notice if they browsed the mirror filesystems and saw both a .tgz and a .tar.gz
But, you're right, it might be worth pushing it out as qpid-proton-0.9.1.tar.gz
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: export.sh creates pax-based tar
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-proton/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: export.sh creates pax-based tar
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the pull request:
https://github.com/apache/qpid-proton/pull/14#issuecomment-87675670
As the archive has already been distributed via the mirror system, I think updating the current named files would likely be considered bad form at this point. I'm not sure how archive.apache.org (which saves the contents even after they are deleted from the mirror system) would react to that either. A quick point release instead perhaps?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: NO-JIRA: export.sh creates pax-based tar
Posted by dnwe <gi...@git.apache.org>.
Github user dnwe commented on the pull request:
https://github.com/apache/qpid-proton/pull/14#issuecomment-87664489
@rhs as we've not announced 0.9 on the website yet, it might be worth re-creating the 0.9 release tar using the updated export.sh and re-uploading it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---