You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Rodolfo Hansen (JIRA)" <ji...@apache.org> on 2010/11/09 22:56:25 UTC
[jira] Created: (WICKET-3154) test for undefined in the same
manner throughtout the code.
test for undefined in the same manner throughtout the code.
------------------------------------------------------------
Key: WICKET-3154
URL: https://issues.apache.org/jira/browse/WICKET-3154
Project: Wicket
Issue Type: Improvement
Components: wicket-extensions
Affects Versions: 1.4.13
Reporter: Rodolfo Hansen
Priority: Trivial
testing whether a variable is undefined should be done in a similar manner throughout a file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3154) test for undefined in the same
manner throughtout the code.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964532#action_12964532 ]
Hudson commented on WICKET-3154:
--------------------------------
Integrated in Apache Wicket 1.4.x #297 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/297/])
WICKET-3154 test for undefined in the same manner throughtout the code.
Always use 'typeof(xyz) <operator> "undefined"'.
It is more safe then using 'xyz <operator> undefined' because window.undefined can be overwritten by buggy/malicious code.
> test for undefined in the same manner throughtout the code.
> ------------------------------------------------------------
>
> Key: WICKET-3154
> URL: https://issues.apache.org/jira/browse/WICKET-3154
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Trivial
> Fix For: 1.4.15, 1.5-M4
>
> Attachments: modal-undefined.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> testing whether a variable is undefined should be done in a similar manner throughout a file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3154) test for undefined in the same
manner throughtout the code.
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3154.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M4
1.4.15
Improved with r1039863 (trunk) and r1039864 (1.4.x).
I chose to use 'typeof(xyz) <operator> "undefined"' because window.undefined can be overwritten by buggy/malicious user code.
> test for undefined in the same manner throughtout the code.
> ------------------------------------------------------------
>
> Key: WICKET-3154
> URL: https://issues.apache.org/jira/browse/WICKET-3154
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Trivial
> Fix For: 1.4.15, 1.5-M4
>
> Attachments: modal-undefined.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> testing whether a variable is undefined should be done in a similar manner throughout a file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3154) test for undefined in the same
manner throughtout the code.
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodolfo Hansen updated WICKET-3154:
-----------------------------------
Attachment: modal.patch
simple patch to keep all tests the same.
> test for undefined in the same manner throughtout the code.
> ------------------------------------------------------------
>
> Key: WICKET-3154
> URL: https://issues.apache.org/jira/browse/WICKET-3154
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Trivial
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> testing whether a variable is undefined should be done in a similar manner throughout a file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3154) test for undefined in the same
manner throughtout the code.
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodolfo Hansen updated WICKET-3154:
-----------------------------------
Attachment: (was: modal.patch)
> test for undefined in the same manner throughtout the code.
> ------------------------------------------------------------
>
> Key: WICKET-3154
> URL: https://issues.apache.org/jira/browse/WICKET-3154
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Trivial
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> testing whether a variable is undefined should be done in a similar manner throughout a file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3154) test for undefined in the same
manner throughtout the code.
Posted by "Rodolfo Hansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodolfo Hansen updated WICKET-3154:
-----------------------------------
Attachment: modal-undefined.patch
> test for undefined in the same manner throughtout the code.
> ------------------------------------------------------------
>
> Key: WICKET-3154
> URL: https://issues.apache.org/jira/browse/WICKET-3154
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.13
> Reporter: Rodolfo Hansen
> Priority: Trivial
> Attachments: modal-undefined.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> testing whether a variable is undefined should be done in a similar manner throughout a file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.