[incubator-uniffle] branch master updated: [MINOR] Replace HashSet with ImmutableSet in configs (#195)

[ro...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 331ebb2a [MINOR] Replace HashSet with ImmutableSet in configs (#195)
331ebb2a is described below

commit 331ebb2a7cd12dfa5d780fc4b0b7d11e9917d343
Author: Kaijie Chen <ck...@apache.org>
AuthorDate: Fri Sep 2 11:27:07 2022 +0800

    [MINOR] Replace HashSet with ImmutableSet in configs (#195)
    
    ### What changes were proposed in this pull request?
    
    Replace HashSet with ImmutableSet in RssMRConfigs and RssSparkConfigs.
    
    ### Why are the changes needed?
    
    It's error prone to use mutable collection in public static fields.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    CI.
---
 .../src/main/java/org/apache/hadoop/mapreduce/RssMRConfig.java      | 6 +++---
 .../src/main/java/org/apache/spark/shuffle/RssSparkConfig.java      | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/client-mr/src/main/java/org/apache/hadoop/mapreduce/RssMRConfig.java b/client-mr/src/main/java/org/apache/hadoop/mapreduce/RssMRConfig.java
index 1c98bdab..eb518162 100644
--- a/client-mr/src/main/java/org/apache/hadoop/mapreduce/RssMRConfig.java
+++ b/client-mr/src/main/java/org/apache/hadoop/mapreduce/RssMRConfig.java
@@ -19,7 +19,7 @@ package org.apache.hadoop.mapreduce;
 
 import java.util.Set;
 
-import com.google.common.collect.Sets;
+import com.google.common.collect.ImmutableSet;
 
 import org.apache.uniffle.client.util.RssClientConfig;
 
@@ -162,6 +162,6 @@ public class RssMRConfig {
   
   public static final String RSS_CONF_FILE = "rss_conf.xml";
 
-  public static final Set<String> RSS_MANDATORY_CLUSTER_CONF = Sets.newHashSet(
-      RSS_STORAGE_TYPE, RSS_REMOTE_STORAGE_PATH);
+  public static final Set<String> RSS_MANDATORY_CLUSTER_CONF =
+      ImmutableSet.of(RSS_STORAGE_TYPE, RSS_REMOTE_STORAGE_PATH);
 }
diff --git a/client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java b/client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java
index 67e29719..5a46da3e 100644
--- a/client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java
+++ b/client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java
@@ -19,7 +19,7 @@ package org.apache.spark.shuffle;
 
 import java.util.Set;
 
-import com.google.common.collect.Sets;
+import com.google.common.collect.ImmutableSet;
 import org.apache.spark.internal.config.ConfigBuilder;
 import org.apache.spark.internal.config.ConfigEntry;
 import org.apache.spark.internal.config.TypedConfigBuilder;
@@ -231,7 +231,7 @@ public class RssSparkConfig {
       .createWithDefault("");
 
   public static final Set<String> RSS_MANDATORY_CLUSTER_CONF =
-      Sets.newHashSet(RSS_STORAGE_TYPE.key(), RSS_REMOTE_STORAGE_PATH.key());
+      ImmutableSet.of(RSS_STORAGE_TYPE.key(), RSS_REMOTE_STORAGE_PATH.key());
 
   public static final boolean RSS_USE_RSS_SHUFFLE_MANAGER_DEFAULT_VALUE = false;