You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "xuzifu666 (via GitHub)" <gi...@apache.org> on 2026/03/09 09:57:22 UTC
[PR] [WIP]feat(bitop): Support DIFF, DIFF1, ANDOR, and ONE for command BITOP [kvrocks]
xuzifu666 opened a new pull request, #3388:
URL: https://github.com/apache/kvrocks/pull/3388
issue: https://github.com/apache/kvrocks/issues/3132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bitop): Support DIFF, DIFF1, ANDOR, and ONE for command BITOP [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on code in PR #3388:
URL: https://github.com/apache/kvrocks/pull/3388#discussion_r2908738043
##########
src/types/redis_bitmap.cc:
##########
Review Comment:
This function is a bit too long (stretching from lines 459 to 800). Could you extract some of the logic into a separate function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bitop): Support DIFF, DIFF1, ANDOR, and ONE for command BITOP [kvrocks]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #3388:
URL: https://github.com/apache/kvrocks/pull/3388#issuecomment-4203316309
> Hi @xuzifu666. Are you still working on this PR?
Sorry, I missed the message. I will continue this work soon. Thanks for reminding me. @jihuayu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bitop): Support DIFF, DIFF1, ANDOR, and ONE for command BITOP [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on PR #3388:
URL: https://github.com/apache/kvrocks/pull/3388#issuecomment-4203303438
Hi @xuzifu666. Are you still working on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bitop): Support DIFF, DIFF1, ANDOR, and ONE for command BITOP [kvrocks]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3388:
URL: https://github.com/apache/kvrocks/pull/3388#issuecomment-4027972059
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=3388) **Quality Gate passed**
Issues
 [19 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=3388&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=3388&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=3388&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [86.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=3388&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=3388&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=3388)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org