You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/02 07:56:53 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #7879: ARROW-9618: [Rust] [DataFusion] Simplified code around optimizers.
jorgecarleitao opened a new pull request #7879:
URL: https://github.com/apache/arrow/pull/7879
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #7879: ARROW-9618: [Rust] [DataFusion] Made it easier to write optimizers
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-672564651
I did a quick review of this PR and it looks good I think. @jorgecarleitao would you mind rebasing it and I'll find time this week for a more thorough review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7879: ARROW-9618: [Rust] [DataFusion] Made it easier to write optimizers
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-668615992
Ups, forgot to change the status. Ready to review, @andygrove .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #7879: ARROW-9618: [Rust] [DataFusion] Made it easier to write optimizers
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-674179387
This looks good to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7879: ARROW-9618: [Rust] [DataFusion] Made it easier to write optimizers
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-672568598
Thanks, @andygrove . This is now rebased.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #7879: ARROW-9618: [Rust] [DataFusion] Made it easier to write optimizers
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-668608855
@jorgecarleitao Is this still a draft or is it ready for review now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7879: ARROW-9618: [Rust] [DataFusion] Made it easier to write optimizers
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-674191488
Incorporated [this comment](https://github.com/apache/arrow/pull/7880#discussion_r470753855) from @alamb and squashed the whole thing in two commits. Thanks @alamb for pushing for the assert there. It makes total sense. 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #7879: ARROW-9618: [Rust] [DataFusion] Made it easier to write optimizers
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-673882408
@alamb , I agree with you that we will need to migrate to a visitor pattern. The goal of this PR is to write functions that walk and re-write the tree, so that we do not have to copy-paste stuff when writing an optimizer. This will make it easier to migrate, since there is well defined pattern in place to migrate from.
@andygrove and @alamb , I rebased this against master again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove closed pull request #7879: ARROW-9618: [Rust] [DataFusion] Made it easier to write optimizers
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #7879:
URL: https://github.com/apache/arrow/pull/7879
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7879: ARROW-9618: [Rust] [DataFusion] Simplified code around optimizers.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7879:
URL: https://github.com/apache/arrow/pull/7879#issuecomment-667643163
https://issues.apache.org/jira/browse/ARROW-9618
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org