You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by geomacy <gi...@git.apache.org> on 2018/02/07 15:10:36 UTC

[GitHub] brooklyn-server pull request #946: Remove unnecessary tearDown step with dup...

GitHub user geomacy opened a pull request:

    https://github.com/apache/brooklyn-server/pull/946

    Remove unnecessary tearDown step with duplicate call of method

    tearDown in EffectorResourceTest is copied from elsewhere but calls
    
            TestRendererHints.clearRegistry();
    
    which is documented to be called from only one test in the suite
    (it's already called from SensorResourceTest).
    
    This change prevents a race condition resulting in intermittent
    failure of SensorResourceTest

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/geomacy/brooklyn-server sensor-resource-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/946.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #946
    
----
commit bcc2842d0e4c42afd1fb0620763c18d3b4da86df
Author: Geoff Macartney <ge...@...>
Date:   2018-02-07T15:09:16Z

    Remove unnecessary tearDown step with duplicate call of method
    
    tearDown in EffectorResourceTest is copied from elsewhere but calls
    
            TestRendererHints.clearRegistry();
    
    which is documented to be called from only one test in the suite
    (it's already called from SensorResourceTest).
    
    This change prevents a race condition resulting in intermittent
    failure of SensorResourceTest

----


---

[GitHub] brooklyn-server issue #946: Remove unnecessary tearDown step with duplicate ...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/946
  
    Thanks @geomacy - merging


---

[GitHub] brooklyn-server pull request #946: Remove unnecessary tearDown step with dup...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/946


---