You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/10 16:24:54 UTC
[GitHub] [kafka] kamalcph opened a new pull request #10099: MINOR: Updated the package name to correct one.
kamalcph opened a new pull request #10099:
URL: https://github.com/apache/kafka/pull/10099
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #10099: MINOR: Updated the package name to correct one.
Posted by GitBox <gi...@apache.org>.
kamalcph commented on pull request #10099:
URL: https://github.com/apache/kafka/pull/10099#issuecomment-776833592
How to resolve this issue in IntelliJ? I've invalidated the IntelliJ cache and built it again but couldn't resolve this one.
<img width="1186" alt="Screenshot 2021-02-10 at 9 54 09 PM" src="https://user-images.githubusercontent.com/11411249/107539263-cbc2e980-6bea-11eb-9f95-201992466ce8.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #10099: MINOR: Updated the package name to correct one.
Posted by GitBox <gi...@apache.org>.
kamalcph commented on pull request #10099:
URL: https://github.com/apache/kafka/pull/10099#issuecomment-777190206
@chia7712
Addressed your review comments. Please take another look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on a change in pull request #10099: MINOR: Updated the package name to correct one.
Posted by GitBox <gi...@apache.org>.
kamalcph commented on a change in pull request #10099:
URL: https://github.com/apache/kafka/pull/10099#discussion_r575945153
##########
File path: core/src/test/scala/integration/kafka/server/IntegrationTestUtils.scala
##########
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package integration.kafka.server
+package kafka.server
Review comment:
@mumrah Can you take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph closed pull request #10099: MINOR: Updated the package name to correct one.
Posted by GitBox <gi...@apache.org>.
kamalcph closed pull request #10099:
URL: https://github.com/apache/kafka/pull/10099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #10099: MINOR: Updated the package name to correct one.
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #10099:
URL: https://github.com/apache/kafka/pull/10099#discussion_r574547061
##########
File path: core/src/test/scala/integration/kafka/server/IntegrationTestUtils.scala
##########
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package integration.kafka.server
+package kafka.server
Review comment:
I feel this package name is intentional. @mumrah WDYY?
##########
File path: checkstyle/import-control-core.xml
##########
@@ -65,7 +65,6 @@
<allow pkg="kafka.api"/>
<allow pkg="kafka.server"/>
<allow pkg="org.apache.kafka.clients.admin"/>
- <allow pkg="integration.kafka.server" class="IntegrationTestHelper"/>
Review comment:
It seems the class `IntegrationTestHelper` was moved due to review comment (#9986)
this should be included by separate PR and the `core/src/test/java/kafka/test/junit/README.md` need to be updated as well.
@mumrah FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on a change in pull request #10099: MINOR: Updated the package name to correct one.
Posted by GitBox <gi...@apache.org>.
kamalcph commented on a change in pull request #10099:
URL: https://github.com/apache/kafka/pull/10099#discussion_r575945086
##########
File path: checkstyle/import-control-core.xml
##########
@@ -65,7 +65,6 @@
<allow pkg="kafka.api"/>
<allow pkg="kafka.server"/>
<allow pkg="org.apache.kafka.clients.admin"/>
- <allow pkg="integration.kafka.server" class="IntegrationTestHelper"/>
Review comment:
Ack. Opened a new PR #10126.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #10099: MINOR: Updated the package name to correct one.
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10099:
URL: https://github.com/apache/kafka/pull/10099#issuecomment-776867882
@kamalcph Thanks for your patch.
1. [ControllerContextTest](https://github.com/apache/kafka/blob/trunk/core/src/test/scala/unit/kafka/controller/ControllerContextTest.scala) has similar issue.
1. the [config](https://github.com/apache/kafka/blob/trunk/core/src/test/scala/kafka/tools/DefaultMessageFormatterTest.scala#L144) need to be updated from `unit.kafka.tools` to `kafka.tools`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org