[GitHub] [httpd] wrowe commented on pull request #133: In Lua 5.4, there is new lua_resume function definition, which has 4 …

[GitBox <gi...@apache.org>]

wrowe commented on pull request #133:
URL: https://github.com/apache/httpd/pull/133#issuecomment-665095226


   Something important to note, the logic in mod_lua confused me... we are ignoring the 2nd arg altogether. I'm not clear why this choice was made since the code and the lua docs don't explain. Given that discrepancy, I'm not entirely sure this works in practice.
   
   Second important thing to note, we wouldn't know, because the test suite doesn't exercise lua_resume.
   
   The patch certainly builds, so the PR is certainly interesting, thanks for submitting!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org