[GitHub] [airflow] mik-laj commented on a change in pull request #6472: [AIRFLOW-6058] Running tests with pytest

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #6472: [AIRFLOW-6058] Running tests with pytest
URL: https://github.com/apache/airflow/pull/6472#discussion_r350306192
 
 

 ##########
 File path: airflow/www/views.py
 ##########
 @@ -1024,12 +1024,12 @@ def blocked(self, session=None):
             )
             if 'all_dags' not in filter_dag_ids:
                 dags = dags.filter(DR.dag_id.in_(filter_dag_ids))
-            dags = dags.all()
 
 Review comment:
   Why did you change it? This should work because all is a method of the query class that retrieves all items that are filtered in the current query. This work differently from "one", which only retrieves first. https://docs.sqlalchemy.org/en/13/orm/query.html#sqlalchemy.orm.query.Query.all

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services