[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4734: Enhance the exception handling in TableRebalancer

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4734: Enhance the exception handling in TableRebalancer
URL: https://github.com/apache/incubator-pinot/pull/4734#discussion_r337605762
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java
 ##########
 @@ -110,11 +117,17 @@ public RebalanceResult rebalance(TableConfig tableConfig, Configuration rebalanc
     // Check if any segment is in ERROR state in ExternalView before rebalancing the table. ERROR state segment cannot
     // be transferred to other state, thus will cause the rebalance to never converge.
     // NOTE: ExternalView might be null when table is just created
-    ExternalView externalView =
-        _helixDataAccessor.getProperty(_helixDataAccessor.keyBuilder().externalView(tableNameWithType));
-    if (externalView != null && hasSegmentInErrorState(externalView.getRecord().getMapFields())) {
-      LOGGER.warn("Found segments in ERROR state for table: {}", tableNameWithType);
-      return new RebalanceResult(RebalanceResult.Status.FAILED, "Found segments in ERROR state", null, null);
+    try {
+      ExternalView externalView =
+          _helixDataAccessor.getProperty(_helixDataAccessor.keyBuilder().externalView(tableNameWithType));
+      if (externalView != null && hasSegmentInErrorState(externalView.getRecord().getMapFields())) {
+        LOGGER.warn("Found segments in ERROR state for table: {}", tableNameWithType);
 
 Review comment:
   Same here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org