You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/12/19 12:35:50 UTC
[GitHub] [submarine] chiaoymir opened a new pull request #839: SUBMARINE-1099. Replace Traefik with Istio in helm-charts
chiaoymir opened a new pull request #839:
URL: https://github.com/apache/submarine/pull/839
### What is this PR for?
<!-- A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html
-->
Replace Traefik with Istio as gateway.
### What type of PR is it?
[Feature]
### Todos
* [x] - Fix static files
* [ ] - Fix minio request
* [ ] - Fix experiment request
### What is the Jira issue?
<!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
* Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title`
-->
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1099?filter=allissues
### How should this be tested?
<!--
* First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
-->
### Screenshots (if appropriate)
<img width="698" alt="Screen Shot 2021-12-19 at 7 01 13 PM" src="https://user-images.githubusercontent.com/41822151/146674952-07fe9c32-8760-4aec-87df-9b7c8a7c48b9.png">
<img width="708" alt="Screen Shot 2021-12-19 at 7 01 53 PM" src="https://user-images.githubusercontent.com/41822151/146674984-66bd6a3b-b817-4ef3-a803-2880ced3bbdb.png">
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] cdmikechen commented on pull request #839: SUBMARINE-1099. Replace Traefik with Istio in helm-charts
Posted by GitBox <gi...@apache.org>.
cdmikechen commented on pull request #839:
URL: https://github.com/apache/submarine/pull/839#issuecomment-997495192
Why not user `helm dependency` to import `istio`?
Maybe we should keep the possibility of two kinds of ingress coexisting, and let users choose their own suitable ingress. In addition, if the user's k8s platform already has its own ingress controller, there is no relevant solution at present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] chiaoymir commented on pull request #839: SUBMARINE-1099. Replace Traefik with Istio in helm-charts
Posted by GitBox <gi...@apache.org>.
chiaoymir commented on pull request #839:
URL: https://github.com/apache/submarine/pull/839#issuecomment-997385174
Unfortunately, I failed to completely replace Traefik with Istio, some endpoints seem broken. However, I don't understand why. Therefore, I think I need to hand off this issue to another person.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org