You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Christian Bürckert (JIRA)" <ji...@apache.org> on 2016/03/11 17:53:39 UTC

[jira] [Issue Comment Deleted] (THRIFT-3669) JS Deserialization of lists of lists is broken

     [ https://issues.apache.org/jira/browse/THRIFT-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Bürckert updated THRIFT-3669:
---------------------------------------
    Comment: was deleted

(was: I'll try to create a valid patch for master and also try to look how the tests are done in Thrift and try to create some as soon as possible.)

> JS Deserialization of lists of lists is broken
> ----------------------------------------------
>
>                 Key: THRIFT-3669
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3669
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Library
>    Affects Versions: 0.9.3, 1.0
>            Reporter: Christian Bürckert
>             Fix For: 0.9.3, 1.0
>
>         Attachments: thrift.js
>
>
> struct QueryResult {
> 	1: required list<list<string>> rows;
> }
> service QueryService{
> 	QueryResult query(); 
> }
> Using TJSONProtocol the list<list<string>> is transmitted correctly but deserialized wrong. Only the first sublist will contain the correct string values the second, third and so on will be empty. The error is a combination of readListBegin, readListEnd and readString (in thrift.js) which somehow interacts wrongly with the internal rstack when lists are included in lists. 
> As a temporary solution until the deserialization is fixed I advice others to create an intermediate struct which contains the sublists.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)