You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Boris Shkolnik (JIRA)" <ji...@apache.org> on 2009/09/08 21:23:57 UTC

[jira] Created: (MAPREDUCE-963) mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.

mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.
-----------------------------------------------------------------------------------------

                 Key: MAPREDUCE-963
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-963
             Project: Hadoop Map/Reduce
          Issue Type: Bug
            Reporter: Boris Shkolnik


We should use org.apache.hadoop.fs.FileAlreadyExistsException instead of org.apache.hadoop.mapred.FileAlreadyExistsException.
Mapred's one should be deprecated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-963) mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated MAPREDUCE-963:
------------------------------------

    Status: Open  (was: Patch Available)

We should updated all references of org.apache.hadoop.mapred.FileAlreadyExistsException to use the one in common. E.g. Streaming, test-cases etc.

> mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-963
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-963
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>         Attachments: MAPREDUCE-963.patch
>
>
> We should use org.apache.hadoop.fs.FileAlreadyExistsException instead of org.apache.hadoop.mapred.FileAlreadyExistsException.
> Mapred's one should be deprecated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-963) mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753256#action_12753256 ] 

Chris Douglas commented on MAPREDUCE-963:
-----------------------------------------

Sorry to be late to this issue, but mapred.FileAlreadyExistsException should extend fs.FileAlreadyExistsException, so 0.21 FAEExceptions won't pass through catches written against earlier versions.

> mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-963
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-963
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 0.21.0
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-963.patch, MAPREDUCE-963.patch
>
>
> We should use org.apache.hadoop.fs.FileAlreadyExistsException instead of org.apache.hadoop.mapred.FileAlreadyExistsException.
> Mapred's one should be deprecated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-963) mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.

Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Boris Shkolnik updated MAPREDUCE-963:
-------------------------------------

    Attachment: MAPREDUCE-963.patch

Good point. I thought I got all of them. Turns out Eclipse missed some of them. :)

> mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-963
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-963
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>         Attachments: MAPREDUCE-963.patch, MAPREDUCE-963.patch
>
>
> We should use org.apache.hadoop.fs.FileAlreadyExistsException instead of org.apache.hadoop.mapred.FileAlreadyExistsException.
> Mapred's one should be deprecated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-963) mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.

Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Boris Shkolnik updated MAPREDUCE-963:
-------------------------------------

    Attachment: MAPREDUCE-963.patch

> mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-963
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-963
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Boris Shkolnik
>         Attachments: MAPREDUCE-963.patch
>
>
> We should use org.apache.hadoop.fs.FileAlreadyExistsException instead of org.apache.hadoop.mapred.FileAlreadyExistsException.
> Mapred's one should be deprecated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-963) mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.

Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Boris Shkolnik updated MAPREDUCE-963:
-------------------------------------

    Status: Patch Available  (was: Open)

> mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-963
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-963
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>         Attachments: MAPREDUCE-963.patch, MAPREDUCE-963.patch
>
>
> We should use org.apache.hadoop.fs.FileAlreadyExistsException instead of org.apache.hadoop.mapred.FileAlreadyExistsException.
> Mapred's one should be deprecated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-963) mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated MAPREDUCE-963:
---------------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I have committed this.  Thanks, Boris!

> mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-963
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-963
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 0.21.0
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-963.patch, MAPREDUCE-963.patch
>
>
> We should use org.apache.hadoop.fs.FileAlreadyExistsException instead of org.apache.hadoop.mapred.FileAlreadyExistsException.
> Mapred's one should be deprecated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-963) mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752915#action_12752915 ] 

Hadoop QA commented on MAPREDUCE-963:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12418996/MAPREDUCE-963.patch
  against trunk revision 812546.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/51/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/51/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/51/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/51/console

This message is automatically generated.

> mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-963
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-963
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>         Attachments: MAPREDUCE-963.patch, MAPREDUCE-963.patch
>
>
> We should use org.apache.hadoop.fs.FileAlreadyExistsException instead of org.apache.hadoop.mapred.FileAlreadyExistsException.
> Mapred's one should be deprecated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-963) mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753222#action_12753222 ] 

Hudson commented on MAPREDUCE-963:
----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #25 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/25/])
    . Deprecate o.a.h.mapred.FileAlreadyExistsException and replace it with o.a.h.fs.FileAlreadyExistsException.  Contributed by Boris Shkolnik


> mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-963
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-963
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 0.21.0
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-963.patch, MAPREDUCE-963.patch
>
>
> We should use org.apache.hadoop.fs.FileAlreadyExistsException instead of org.apache.hadoop.mapred.FileAlreadyExistsException.
> Mapred's one should be deprecated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-963) mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated MAPREDUCE-963:
---------------------------------------------

    Affects Version/s: 0.21.0
        Fix Version/s: 0.21.0
           Issue Type: Improvement  (was: Bug)
         Release Note: Deprecate o.a.h.mapred.FileAlreadyExistsException and replace it with o.a.h.fs.FileAlreadyExistsException.

> mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-963
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-963
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 0.21.0
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-963.patch, MAPREDUCE-963.patch
>
>
> We should use org.apache.hadoop.fs.FileAlreadyExistsException instead of org.apache.hadoop.mapred.FileAlreadyExistsException.
> Mapred's one should be deprecated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-963) mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated MAPREDUCE-963:
---------------------------------------------

        Assignee: Boris Shkolnik
    Hadoop Flags: [Incompatible change, Reviewed]  (was: [Incompatible change])
          Status: Patch Available  (was: Open)

+1 patch looks good.

> mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-963
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-963
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>         Attachments: MAPREDUCE-963.patch
>
>
> We should use org.apache.hadoop.fs.FileAlreadyExistsException instead of org.apache.hadoop.mapred.FileAlreadyExistsException.
> Mapred's one should be deprecated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-963) mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753257#action_12753257 ] 

Chris Douglas commented on MAPREDUCE-963:
-----------------------------------------

Wait... scratch that; I have it backwards. We lose, nevermind.

> mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-963
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-963
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 0.21.0
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-963.patch, MAPREDUCE-963.patch
>
>
> We should use org.apache.hadoop.fs.FileAlreadyExistsException instead of org.apache.hadoop.mapred.FileAlreadyExistsException.
> Mapred's one should be deprecated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-963) mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752851#action_12752851 ] 

Hadoop QA commented on MAPREDUCE-963:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12418981/MAPREDUCE-963.patch
  against trunk revision 812546.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/18/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/18/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/18/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/18/console

This message is automatically generated.

> mapred's FileAlreadyExistsException should be deprecated in favor of hadoop-common's one.
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-963
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-963
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>         Attachments: MAPREDUCE-963.patch, MAPREDUCE-963.patch
>
>
> We should use org.apache.hadoop.fs.FileAlreadyExistsException instead of org.apache.hadoop.mapred.FileAlreadyExistsException.
> Mapred's one should be deprecated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.