You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2009/06/02 18:19:20 UTC
[Bug 6122] New: Mail::DKIM 0.34 removed DkimPolicy::as_string, which
was used in dbg call
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6122
Summary: Mail::DKIM 0.34 removed DkimPolicy::as_string, which was
used in dbg call
Product: Spamassassin
Version: 3.2.5
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P5
Component: Libraries
AssignedTo: dev@spamassassin.apache.org
ReportedBy: Mark.Martinec@ijs.si
Created an attachment (id=4457)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4457)
comment out a dbg call
This is rather trivial. The Plugin::DKIM is calling a routine
Mail::DKIM::DkimPolicy::as_string within a dbg() call.
The version 0.34 of Mail::DKIM removed sub as_string,
so the following error results:
[15007] dbg: dkim: lookup failed:
Can't locate object method "as_string" via package
"Mail::DKIM::DkimPolicy"
at /usr/local/lib/perl5/site_perl/5.10.0/Mail/SpamAssassin/Plugin/DKIM.pm
line 474.
If there will ever be a 3.2.6, the attached quick patch just
comments out the dbg call, it is non-essential.
Note that 3.3 is unaffected by the change in Mail::DKIM 0.34, it
already uses its different API to fetch author signing domain policy.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6122] [review] Mail::DKIM 0.34 removed DkimPolicy::as_string,
which was used in dbg call
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6122
Karsten Bräckelmann <gu...@rudersport.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes for 3.2 |needs 1 vote for 3.2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6122] [review] Mail::DKIM 0.34 removed DkimPolicy::as_string,
which was used in dbg call
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6122
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |minor
--- Comment #4 from Mark Martinec <Ma...@ijs.si> 2009-06-09 02:13:20 PST ---
Thanks to Kevin for contacting the author of Mail::DKIM, the version 0.36
has been published, making the missing Mail::DKIM::DkimPolicy::as_string
available again. So the attached patch is only necessary for versions
0.34 and 0.35, but it does no harm to other versions (except for less
informative log entry).
There are two choices now, go on with the patch, or require a 0.36+ .
I'd still go with the patch, but the need for it is much reduced now.
My reason for dropping the logging of a policy is that this area
of SSP/ADSP processing has been much revised, both in the IETF WG,
in the Mail::DKIM plugin and in the version of DKIM Plugin in SA 3.3,
so the code section we are discussing here will go away sooner or later.
We are only discussing a quick fix here.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6122] [review] Mail::DKIM 0.34 removed DkimPolicy::as_string,
which was used in dbg call
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6122
--- Comment #3 from Karsten Bräckelmann <gu...@rudersport.de> 2009-06-02 15:42:14 PST ---
+1 on the second patch
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6122] [review] Mail::DKIM 0.34 removed DkimPolicy::as_string,
which was used in dbg call
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6122
Darxus <Da...@ChaosReigns.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Darxus@ChaosReigns.com
--- Comment #7 from Darxus <Da...@ChaosReigns.com> 2011-05-23 17:51:10 UTC ---
Needs 1 vote to commit to 3.2, which looks like it has less complications than
changing the Mail::DKIM requirement to v0.36+.
Does not affect 3.3.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6122] [review] Mail::DKIM 0.34 removed DkimPolicy::as_string,
which was used in dbg call
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6122
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Mail::DKIM 0.34 removed |[review] Mail::DKIM 0.34
|DkimPolicy::as_string, which|removed
|was used in dbg call |DkimPolicy::as_string, which
| |was used in dbg call
Status Whiteboard| |needs 2 votes for 3.2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6122] [review] Mail::DKIM 0.34 removed DkimPolicy::as_string,
which was used in dbg call
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6122
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4457 is|0 |1
obsolete| |
--- Comment #2 from Mark Martinec <Ma...@ijs.si> 2009-06-02 10:39:13 PST ---
Created an attachment (id=4458)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4458)
simplifies the dbg call
Makese sense, thanks. Here is a new patch.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6122] [review] Mail::DKIM 0.34 removed DkimPolicy::as_string,
which was used in dbg call
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6122
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@pccc.com
--- Comment #5 from Kevin A. McGrail <km...@pccc.com> 2010-05-25 18:25:05 EDT ---
(In reply to comment #4)
> Thanks to Kevin for contacting the author of Mail::DKIM, the version 0.36
> has been published, making the missing Mail::DKIM::DkimPolicy::as_string
> available again. So the attached patch is only necessary for versions
> 0.34 and 0.35, but it does no harm to other versions (except for less
> informative log entry).
>
> There are two choices now, go on with the patch, or require a 0.36+ .
> I'd still go with the patch, but the need for it is much reduced now.
>
> My reason for dropping the logging of a policy is that this area
> of SSP/ADSP processing has been much revised, both in the IETF WG,
> in the Mail::DKIM plugin and in the version of DKIM Plugin in SA 3.3,
> so the code section we are discussing here will go away sooner or later.
> We are only discussing a quick fix here.
+1 to require 0.36+ of DKIM for 3.3.X next realease. It's been almost a year
since this issue was resolved by the author of DKIM.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Re: Next version of SpamAssassin to require newer DKIM library
Posted by Alexander Wirt <fo...@formorer.de>.
Adam Katz schrieb am Tuesday, den 25. May 2010:
> Hello Debian Backports team*
>
> I'd like to request a backport of libmail-dkim-perl at version 0.36 or
> higher for Debian Lenny before we release SpamAssassin 3.3.2 which
> will depend on it.
As the maintainer of the SA backport I'l take care about the issue.
Thanks for the notice!
Alex
Next version of SpamAssassin to require newer DKIM library
Posted by Adam Katz <an...@khopis.com>.
Hello Debian Backports team*
I'd like to request a backport of libmail-dkim-perl at version 0.36 or
higher for Debian Lenny before we release SpamAssassin 3.3.2 which
will depend on it.
This should keep everybody on the same page.
Thanks,
Adam Katz
SpamAssassin Committer
> https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6122
>
> --- Comment #6 from Adam Katz <an...@khopis.com> ---
> (In reply to comment #5)
>> +1 to require 0.36+ of DKIM for 3.3.X next realease. It's been
>> almost a year since this issue was resolved by the author of
>> DKIM.
>
> spamassassin 3.3.x is in lenny-backports but libmail-dkim-perl is
> not present there. I'm willing to give my vote only if the newly
> required version of DKIM finds its way to Debian Stable via
> backports, volatile, or some other supported production-grade
> repository ... or if this particular issue's solution is otherwise
> back-ported into a debian-packaged DKIM.
>
> I'll forward the email this comment generates to the Debian
> Backports team as a request on that front.
* This email was in the "Feedback" link on www.backports.org ... I do
not see an admin or developers address or other request mechanism.
Sorry if this is inappropriate!
[Bug 6122] [review] Mail::DKIM 0.34 removed DkimPolicy::as_string,
which was used in dbg call
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6122
Adam Katz <an...@khopis.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |antispam@khopis.com
--- Comment #6 from Adam Katz <an...@khopis.com> 2010-05-25 20:01:51 EDT ---
(In reply to comment #5)
> +1 to require 0.36+ of DKIM for 3.3.X next realease. It's been almost a year
> since this issue was resolved by the author of DKIM.
spamassassin 3.3.x is in lenny-backports but libmail-dkim-perl is not present
there. I'm willing to give my vote only if the newly required version of DKIM
finds its way to Debian Stable via backports, volatile, or some other supported
production-grade repository ... or if this particular issue's solution is
otherwise back-ported into a debian-packaged DKIM.
I'll forward the email this comment generates to the Debian Backports team as a
request on that front.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6122] [review] Mail::DKIM 0.34 removed DkimPolicy::as_string,
which was used in dbg call
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6122
--- Comment #1 from Kevin A. McGrail <km...@pccc.com> 2009-06-02 10:00:24 PST ---
-1 on the patch but in spirit it's a simple patch and I have a nuance change.
Assuming there is no replacement for the as_string function that is likely
below the intended external API availability, I would keep the debug line but
remove the as_string call. i.e.:
dbg("dkim: policy result $policy_result");
But I'll also ask the DKIM module author if he has a recommendation.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6122] [review] Mail::DKIM 0.34 removed DkimPolicy::as_string,
which was used in dbg call
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6122
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #8 from Mark Martinec <Ma...@ijs.si> 2011-05-23 18:39:26 UTC ---
> Needs 1 vote to commit to 3.2, which looks like it has less complications than
> changing the Mail::DKIM requirement to v0.36+.
> Does not affect 3.3.
This is really a trivial patch to a debugging entry in 3.2, so I'll apply
it to 3.2 and close the ticket, despite the fact that 3.2.6 probably
won't be released at all, and that we are lacking one vote.
The problem has long been fixed in 3.3.
3.2: (!)
Bug 6122: Mail::DKIM 0.34 removed DkimPolicy::as_string,
which was used in dbg call
Sending lib/Mail/SpamAssassin/Plugin/DKIM.pm
Committed revision 1126649.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.