[GitHub] [incubator-mxnet] zhreshold commented on a change in pull request #16078: [Dataset] Add take, filter API to dataset

[GitBox <gi...@apache.org>]

zhreshold commented on a change in pull request #16078: [Dataset] Add take, filter API to dataset
URL: https://github.com/apache/incubator-mxnet/pull/16078#discussion_r320407962
 
 

 ##########
 File path: python/mxnet/gluon/data/dataset.py
 ##########
 @@ -40,6 +40,41 @@ def __getitem__(self, idx):
     def __len__(self):
         raise NotImplementedError
 
+    def filter(self, fn):
 
 Review comment:
   Is it better in some cases that lazy evaluation should be applied after `filter`, i.e., 
   
   data.filter(xxx).transform is way better than data.transform.filter in some situations.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services