[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10868: ESLint: Re-enable rule default-props-match-prop-types

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #10868:
URL: https://github.com/apache/incubator-superset/pull/10868#discussion_r488409236



##########
File path: superset-frontend/src/dashboard/components/ColorSchemeControlWrapper.jsx
##########
@@ -30,7 +30,6 @@ const propTypes = {
 
 const defaultProps = {
   colorScheme: undefined,
-  onChange: () => {},

Review comment:
       this one is making me nervous, can we remove the `.isRequired` instead?

##########
File path: superset-frontend/src/dashboard/components/DashboardBuilder.jsx
##########
@@ -64,7 +64,6 @@ const propTypes = {
 };
 
 const defaultProps = {
-  showBuilderPane: false,

Review comment:
       seems less risky to remove the `.isRequired` here too  (unless you can confirm you checked all the calls)

##########
File path: superset-frontend/src/dashboard/components/SliceAdder.jsx
##########
@@ -45,7 +45,6 @@ const propTypes = {
 };
 
 const defaultProps = {
-  selectedSliceIds: [],

Review comment:
       let's remove `.isRequired` here to (unless you can confirm you checked all the calls)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org