[GitHub] [incubator-superset] dpgaspar opened a new pull request #8693: [appfactory] Fix, jinja context

[GitBox <gi...@apache.org>]

dpgaspar opened a new pull request #8693: [appfactory] Fix, jinja context
URL: https://github.com/apache/incubator-superset/pull/8693
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Following the ongoing process for converting superset to the app factory pattern.
   
   Docs were unable to build properly since the autofunction import a method on a module that needs a Flask app context.
   
   Adding also a test for building superset docs
   
   ### TEST PLAN
   - Test sqllab jinja templates
   - Test build docs
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org