You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "orpiske (via GitHub)" <gi...@apache.org> on 2024/01/19 10:43:48 UTC
[PR] CAMEL-20294: remove camel-facebook [camel]
orpiske opened a new pull request, #12843:
URL: https://github.com/apache/camel/pull/12843
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20294: remove camel-facebook [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #12843:
URL: https://github.com/apache/camel/pull/12843#issuecomment-1900418734
> TODO: also remove the component on Camel Spring Boot.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20294: remove camel-facebook [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #12843:
URL: https://github.com/apache/camel/pull/12843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20294: remove camel-facebook [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #12843:
URL: https://github.com/apache/camel/pull/12843#discussion_r1458948499
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_4.adoc:
##########
@@ -130,6 +130,10 @@ Replaced the previous JSONata library with a new one that offers complete compat
The JdbcAggregationRepository now provides a deserializationFilter parameter. The default value for it is allowing all java packages and subpackages and all org.apache.camel packages and subpackages. If you plan to use particular classes and you want to expand the filter, you should change the value according to your needs. More details in CAMEL-20303.
+=== camel-facebook
+
+The component was removed without deprecation. The library supporting this component has been unmaintained for a long time. We found no indications that the library itself no the component are working with modern Facebook, along with the absense of community interest.
Review Comment:
isn't a portion of sentence missing going with `along with the absense of community interest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20294: remove camel-facebook [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #12843:
URL: https://github.com/apache/camel/pull/12843#issuecomment-1900169757
TODO: also remove the component on Camel Spring Boot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20294: remove camel-facebook [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #12843:
URL: https://github.com/apache/camel/pull/12843#discussion_r1458946377
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_4.adoc:
##########
@@ -130,6 +130,10 @@ Replaced the previous JSONata library with a new one that offers complete compat
The JdbcAggregationRepository now provides a deserializationFilter parameter. The default value for it is allowing all java packages and subpackages and all org.apache.camel packages and subpackages. If you plan to use particular classes and you want to expand the filter, you should change the value according to your needs. More details in CAMEL-20303.
+=== camel-facebook
+
+The component was removed without deprecation. The library supporting this component has been unmaintained for a long time. We found no indications that the library itself no the component are working with modern Facebook, along with the absense of community interest.
Review Comment:
```suggestion
The component was removed without deprecation. The library supporting this component has been unmaintained for a long time. We found no indications that the library itself nor the component are working with modern Facebook, along with the absence of community interest.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20294: remove camel-facebook [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #12843:
URL: https://github.com/apache/camel/pull/12843#discussion_r1458954118
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_4.adoc:
##########
@@ -130,6 +130,10 @@ Replaced the previous JSONata library with a new one that offers complete compat
The JdbcAggregationRepository now provides a deserializationFilter parameter. The default value for it is allowing all java packages and subpackages and all org.apache.camel packages and subpackages. If you plan to use particular classes and you want to expand the filter, you should change the value according to your needs. More details in CAMEL-20303.
+=== camel-facebook
+
+The component was removed without deprecation. The library supporting this component has been unmaintained for a long time. We found no indications that the library itself no the component are working with modern Facebook, along with the absense of community interest.
Review Comment:
Good catch. It was missing, indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20294: remove camel-facebook [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12843:
URL: https://github.com/apache/camel/pull/12843#issuecomment-1900169221
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org