[GitHub] spark issue #18069: [SPARK-20850][SQL]Improve division and multiplication mi...

[hvanhovell <gi...@git.apache.org>]

Github user hvanhovell commented on the issue:

    https://github.com/apache/spark/pull/18069
  
    I don't think this makes any sense:
    
    - The parser is not the place where you should make this change. This should be done in `TypeCoercion`. Now we create different semantics between SQL and the DataFrame API.
    - This is a breaking change to result type of `Divide`, and will probably break Hive compatibility. This is going break to user code in a lot of places. I also think it is weird that we are going to always return `Double` when a `Decimal` is completely valid. 
    - I think MySql returns a `Decimal` and not a `Double`.
    
    So I am going to -1 this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org