You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by brandtg <gi...@git.apache.org> on 2016/08/25 20:14:51 UTC
[GitHub] helix pull request #48: helix-ui improvements
GitHub user brandtg opened a pull request:
https://github.com/apache/helix/pull/48
helix-ui improvements
We are running a couple systems now at Airbnb using Helix, and have made some improvements / bug fixes to the UI.
Specifically,
* Adding zkAliases to configuration (to access well-defined zk clusters by logical name)
* Instance group tags on the instances table
* Controller leader instance on cluster page
* User can reset a resource in non-admin mode (to move partitions out of ERROR state)
* Fix FULL_AUTO bug (was brought up on user@, and saw problem internally)
to: @kanakb @kishoreg @zzhang5
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brandtg/helix master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/48.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #48
----
commit 70a29bfb03bae1b06a2d287f436ac14fdc149c68
Author: Greg Brandt <gr...@airbnb.com>
Date: 2016-07-14T21:00:43Z
Adds zkAliases to helix-ui configuration
`zkAliases` is a map of alias to ZK connection string. If this is provided,
then one can use the alias in place of the zk connection string in
`/dashboard/{zk}` route. In addition, the root `/dashboard` route will allow
the user to choose among the aliases as opposed to pasting in a zk connection
string.
commit 23d32cc299498e1a197f368df9a8b21b66e07604
Author: Greg Brandt <gr...@airbnb.com>
Date: 2016-07-15T05:43:04Z
Add ping / health resources
commit cb17c17bde0b17c22ab6b291de5d5115c6a8d9b3
Author: Greg Brandt <gr...@airbnb.com>
Date: 2016-08-04T18:31:29Z
Add tags to instance table
commit 9034545fb896635dfa62ad8e7101ad65e9958952
Author: Greg Brandt <gr...@airbnb.com>
Date: 2016-08-05T22:25:27Z
Show controller leader in UI
commit ac925b7e63b64420cfddcf04bc1795c77807d0b4
Author: Greg Brandt <gr...@airbnb.com>
Date: 2016-08-25T17:30:36Z
Add reset resource button to helix-ui
commit 7e51fc6d30de95ed91df64de5b4044eee27d1ac8
Author: Greg Brandt <gr...@airbnb.com>
Date: 2016-08-25T17:54:47Z
Fix FULL_AUTO bug
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix issue #48: helix-ui improvements
Posted by kishoreg <gi...@git.apache.org>.
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/48
Got it. Will review this. Are you guys using 0.6.x or 0.7.x
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix issue #48: helix-ui improvements
Posted by brandtg <gi...@git.apache.org>.
Github user brandtg commented on the issue:
https://github.com/apache/helix/pull/48
@kishoreg Sorry I should have been more clear - the FULL_AUTO bug was a problem in which the UI wouldn't show the table containing partition / ideal state / external view, as there is no state map information in a FULL_AUTO resource's ideal state. This doesn't touch the FULL_AUTO logic in `helix-core`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix issue #48: helix-ui improvements
Posted by brandtg <gi...@git.apache.org>.
Github user brandtg commented on the issue:
https://github.com/apache/helix/pull/48
0.6.x because the beta label was a hard sell \U0001f604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request #48: helix-ui improvements
Posted by brandtg <gi...@git.apache.org>.
Github user brandtg closed the pull request at:
https://github.com/apache/helix/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix issue #48: helix-ui improvements
Posted by kishoreg <gi...@git.apache.org>.
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/48
this is awesome Greg, can you please create a separate PR for FULL_AUTO bug. I will review the changes tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix issue #48: helix-ui improvements
Posted by kishoreg <gi...@git.apache.org>.
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/48
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix issue #48: helix-ui improvements
Posted by brandtg <gi...@git.apache.org>.
Github user brandtg commented on the issue:
https://github.com/apache/helix/pull/48
Ah here is the JIRA https://issues.apache.org/jira/browse/HELIX-627
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix issue #48: helix-ui improvements
Posted by kishoreg <gi...@git.apache.org>.
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/48
@lei-xia can you also review this change. Subbu had a test case https://issues.apache.org/jira/browse/HELIX-631. Will be good to see if this change fixes that as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---