[jira] [Commented] (SOLR-9641) Emit distributed tracing information from Solr

["David Smiley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588732#comment-15588732 ] 

David Smiley commented on SOLR-9641:
------------------------------------

This is really cool [~mdrob]!  I learned about tracing at Apache Big Data this year and I became hopeful that one day Solr would get tracing abilities.  Can you recommend a tool that can be used with Solr after this patch is applied to visualize or otherwise make use of it to help us analyze Solr performance?

I looked at the patch; the approach is overall quite nice I think.  Some comments:
* SolrCore.newScope: guard log.debug with log.isDebugEnabled to avoid toString 
* loadTraceConfig: could you use NamedList.asMap(1)  or perhaps not because "String" type?
* TracerUtils: I like this. Question: should newScope(SolrQueryRequest request, String description) also look in the request params to see if there is a parent, and if so conditionally call tracer.newScope with that parent?
* HttpShardHandler: maybe instead of always wrapping task with traceTask we instead conditionally replace task with a tracing one?  This way we conveniently avoid the wrapping if there is no tracing.
* CommonParams.java:TRACE_ID: a one-liner comment referencing "HTrace" would be useful.

> Emit distributed tracing information from Solr
> ----------------------------------------------
>
>                 Key: SOLR-9641
>                 URL: https://issues.apache.org/jira/browse/SOLR-9641
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mike Drob
>             Fix For: master (7.0)
>
>         Attachments: SOLR-9641.patch
>
>
> While Solr already offers a few tools for exposing timing, this information can be difficult to aggregate and analyze. By integrating distributed tracing into Solr operations, we can gain new performance and behaviour insights.
> One such solution can be accomplished via Apache HTrace (incubating).
> (More rationale to follow.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org