You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vineet Garg <vg...@hortonworks.com> on 2017/12/02 21:58:00 UTC
Review Request 64282: HIVE-18173: Improve plans for correlated
subqueries with non-equi predicate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64282/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-18173
https://issues.apache.org/jira/browse/HIVE-18173
Repository: hive-git
Description
-------
Improve plans for correlated subqueries with non-equi predicate
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java d1fe49c875
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 76c82e2606
ql/src/test/queries/clientpositive/subquery_in.q 7d4ece9dca
ql/src/test/results/clientpositive/llap/explainuser_1.q.out 5adf401b25
ql/src/test/results/clientpositive/llap/subquery_exists.q.out dfe424046e
ql/src/test/results/clientpositive/llap/subquery_in.q.out 5dcdfdd15f
ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 0ffbaaea34
ql/src/test/results/clientpositive/llap/subquery_multi.q.out d0a78a2bb4
ql/src/test/results/clientpositive/llap/subquery_notin.q.out 5da12584f0
ql/src/test/results/clientpositive/llap/subquery_scalar.q.out ab67a7dc59
ql/src/test/results/clientpositive/llap/subquery_select.q.out d41704661d
ql/src/test/results/clientpositive/llap/subquery_views.q.out af695691a7
ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 6a4bea1bd4
ql/src/test/results/clientpositive/spark/subquery_exists.q.out fb13fb73e9
ql/src/test/results/clientpositive/spark/subquery_in.q.out e19240b7ca
ql/src/test/results/clientpositive/spark/subquery_multi.q.out a4282df08a
ql/src/test/results/clientpositive/spark/subquery_notin.q.out 0d12d0db60
ql/src/test/results/clientpositive/spark/subquery_scalar.q.out d8b1c92526
ql/src/test/results/clientpositive/spark/subquery_select.q.out 6feb852965
ql/src/test/results/clientpositive/spark/subquery_views.q.out 9a1c25fffd
ql/src/test/results/clientpositive/subquery_exists.q.out b6b31aaf47
ql/src/test/results/clientpositive/subquery_notexists.q.out a6175f8fec
ql/src/test/results/clientpositive/subquery_notin_having.q.out 433609d016
ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out bfb5d2b0a6
Diff: https://reviews.apache.org/r/64282/diff/1/
Testing
-------
Thanks,
Vineet Garg
Re: Review Request 64282: HIVE-18173: Improve plans for correlated
subqueries with non-equi predicate
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64282/#review193025
-----------------------------------------------------------
ql/src/test/queries/clientpositive/subquery_in.q
Line 305 (original), 305-313 (patched)
<https://reviews.apache.org/r/64282/#comment271519>
Can you please add these queries in a new q file for MiniLlapDriver only. Current q.out is very large and its hard to understand impact of this patch on existing tests because of large diff size.
ql/src/test/results/clientpositive/llap/subquery_in.q.out
Lines 1029-1034 (original)
<https://reviews.apache.org/r/64282/#comment271518>
This query is now returning empty result set. Looks incorrect.
- Ashutosh Chauhan
On Dec. 6, 2017, 6:30 a.m., Vineet Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64282/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2017, 6:30 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-18173
> https://issues.apache.org/jira/browse/HIVE-18173
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Improve plans for correlated subqueries with non-equi predicate
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java d1fe49c875
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 76c82e2606
> ql/src/test/queries/clientpositive/subquery_in.q 7d4ece9dca
> ql/src/test/results/clientpositive/llap/subquery_exists.q.out dfe424046e
> ql/src/test/results/clientpositive/llap/subquery_in.q.out 5dcdfdd15f
> ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 0ffbaaea34
> ql/src/test/results/clientpositive/llap/subquery_notin.q.out 5da12584f0
> ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 6a4bea1bd4
> ql/src/test/results/clientpositive/spark/subquery_exists.q.out fb13fb73e9
> ql/src/test/results/clientpositive/spark/subquery_in.q.out e19240b7ca
> ql/src/test/results/clientpositive/spark/subquery_multi.q.out a4282df08a
> ql/src/test/results/clientpositive/spark/subquery_notin.q.out 0d12d0db60
> ql/src/test/results/clientpositive/spark/subquery_scalar.q.out d8b1c92526
> ql/src/test/results/clientpositive/spark/subquery_select.q.out 6feb852965
> ql/src/test/results/clientpositive/spark/subquery_views.q.out 9a1c25fffd
> ql/src/test/results/clientpositive/subquery_exists.q.out b6b31aaf47
> ql/src/test/results/clientpositive/subquery_notexists.q.out a6175f8fec
>
>
> Diff: https://reviews.apache.org/r/64282/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vineet Garg
>
>
Re: Review Request 64282: HIVE-18173: Improve plans for correlated
subqueries with non-equi predicate
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64282/#review193067
-----------------------------------------------------------
ql/src/test/results/clientpositive/llap/subquery_in.q.out
Lines 1029-1037 (original)
<https://reviews.apache.org/r/64282/#comment271564>
still wrong result set.
- Ashutosh Chauhan
On Dec. 6, 2017, 11:58 p.m., Vineet Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64282/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2017, 11:58 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-18173
> https://issues.apache.org/jira/browse/HIVE-18173
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Improve plans for correlated subqueries with non-equi predicate
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties cca1055fde
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java d1fe49c875
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 76c82e2606
> ql/src/test/queries/clientpositive/subquery_corr.q PRE-CREATION
> ql/src/test/results/clientpositive/llap/subquery_corr.q.out PRE-CREATION
> ql/src/test/results/clientpositive/llap/subquery_exists.q.out dfe424046e
> ql/src/test/results/clientpositive/llap/subquery_in.q.out 5dcdfdd15f
> ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 0ffbaaea34
> ql/src/test/results/clientpositive/llap/subquery_notin.q.out 5da12584f0
> ql/src/test/results/clientpositive/spark/subquery_exists.q.out fb13fb73e9
> ql/src/test/results/clientpositive/spark/subquery_in.q.out e19240b7ca
> ql/src/test/results/clientpositive/spark/subquery_multi.q.out a4282df08a
> ql/src/test/results/clientpositive/spark/subquery_notin.q.out 0d12d0db60
> ql/src/test/results/clientpositive/subquery_exists.q.out b6b31aaf47
> ql/src/test/results/clientpositive/subquery_notexists.q.out a6175f8fec
>
>
> Diff: https://reviews.apache.org/r/64282/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vineet Garg
>
>
Re: Review Request 64282: HIVE-18173: Improve plans for correlated
subqueries with non-equi predicate
Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64282/
-----------------------------------------------------------
(Updated Dec. 6, 2017, 11:58 p.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------
Rebased patch
Bugs: HIVE-18173
https://issues.apache.org/jira/browse/HIVE-18173
Repository: hive-git
Description
-------
Improve plans for correlated subqueries with non-equi predicate
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties cca1055fde
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java d1fe49c875
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 76c82e2606
ql/src/test/queries/clientpositive/subquery_corr.q PRE-CREATION
ql/src/test/results/clientpositive/llap/subquery_corr.q.out PRE-CREATION
ql/src/test/results/clientpositive/llap/subquery_exists.q.out dfe424046e
ql/src/test/results/clientpositive/llap/subquery_in.q.out 5dcdfdd15f
ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 0ffbaaea34
ql/src/test/results/clientpositive/llap/subquery_notin.q.out 5da12584f0
ql/src/test/results/clientpositive/spark/subquery_exists.q.out fb13fb73e9
ql/src/test/results/clientpositive/spark/subquery_in.q.out e19240b7ca
ql/src/test/results/clientpositive/spark/subquery_multi.q.out a4282df08a
ql/src/test/results/clientpositive/spark/subquery_notin.q.out 0d12d0db60
ql/src/test/results/clientpositive/subquery_exists.q.out b6b31aaf47
ql/src/test/results/clientpositive/subquery_notexists.q.out a6175f8fec
Diff: https://reviews.apache.org/r/64282/diff/6/
Changes: https://reviews.apache.org/r/64282/diff/5-6/
Testing
-------
Thanks,
Vineet Garg
Re: Review Request 64282: HIVE-18173: Improve plans for correlated
subqueries with non-equi predicate
Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64282/
-----------------------------------------------------------
(Updated Dec. 6, 2017, 8:37 p.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------
This change addresses review comments
Bugs: HIVE-18173
https://issues.apache.org/jira/browse/HIVE-18173
Repository: hive-git
Description
-------
Improve plans for correlated subqueries with non-equi predicate
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 75b77072c6
itests/hive-unit/pom.xml 3a435a8a52
itests/hive-unit/src/test/java/org/apache/hive/jdbc/AbstractJdbcTriggersTest.java 62ee66f717
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersMoveWorkloadManager.java 74ca958ea8
itests/src/test/resources/testconfiguration.properties cca1055fde
metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 02288cbe42
metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 915af8bf4b
ql/src/java/org/apache/hadoop/hive/ql/Context.java 6d48783d48
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4d52d748f1
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/AmPluginNode.java eb6442180b
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/KillMoveTriggerActionHandler.java b16f1c30a0
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/KillTriggerActionHandler.java 50d234deaa
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java dd879fc5e8
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 8795cfcee1
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TriggerValidatorRunnable.java 6414f05fe0
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmEvent.java 33341ad4a9
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java e78ef44c11
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java dbdbbf25db
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManagerFederation.java 9d56204240
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/PrintSummary.java 8414c73e2b
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java 9726af1506
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 0ad68166ae
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToBoolean.java 7a44035337
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncStringToLong.java 5c0a7fae56
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpression.java 8c2894b482
ql/src/java/org/apache/hadoop/hive/ql/hooks/PostExecWMEventsSummaryPrinter.java 83cca8903b
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java d1fe49c875
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 76c82e2606
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 07742e0485
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java 57949d90aa
ql/src/java/org/apache/hadoop/hive/ql/wm/Trigger.java 4adad7a1b6
ql/src/java/org/apache/hadoop/hive/ql/wm/TriggerActionHandler.java 7995a8f639
ql/src/java/org/apache/hadoop/hive/ql/wm/TriggerContext.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/wm/WmContext.java 7a7ef507e5
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java c58e4507f2
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorMathFunctions.java e89f2e5a02
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java 6952b4598f
ql/src/test/queries/clientpositive/groupby_position.q 446b99d3cb
ql/src/test/queries/clientpositive/subquery_corr.q PRE-CREATION
ql/src/test/queries/clientpositive/subquery_in.q 7d4ece9dca
ql/src/test/queries/clientpositive/udf_to_boolean.q 1a50d055d5
ql/src/test/queries/clientpositive/vector_udf_string_to_boolean.q eeb5ab8819
ql/src/test/results/clientpositive/groupby_position.q.out 7351a06f9c
ql/src/test/results/clientpositive/llap/insert_values_orig_table_use_metadata.q.out 143742b3be
ql/src/test/results/clientpositive/llap/subquery_corr.q.out PRE-CREATION
ql/src/test/results/clientpositive/llap/subquery_exists.q.out dfe424046e
ql/src/test/results/clientpositive/llap/subquery_in.q.out 5dcdfdd15f
ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 0ffbaaea34
ql/src/test/results/clientpositive/llap/subquery_notin.q.out 5da12584f0
ql/src/test/results/clientpositive/llap/vectorized_casts.q.out 84b4d9454d
ql/src/test/results/clientpositive/spark/groupby_position.q.out bcc512be09
ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 6a4bea1bd4
ql/src/test/results/clientpositive/spark/subquery_exists.q.out fb13fb73e9
ql/src/test/results/clientpositive/spark/subquery_in.q.out e19240b7ca
ql/src/test/results/clientpositive/spark/subquery_multi.q.out a4282df08a
ql/src/test/results/clientpositive/spark/subquery_notin.q.out 0d12d0db60
ql/src/test/results/clientpositive/subquery_exists.q.out b6b31aaf47
ql/src/test/results/clientpositive/subquery_notexists.q.out a6175f8fec
ql/src/test/results/clientpositive/udf_to_boolean.q.out bee030ab92
ql/src/test/results/clientpositive/vector_empty_where.q.out 6b2c7fefa2
ql/src/test/results/clientpositive/vector_udf_string_to_boolean.q.out 1b06698bca
ql/src/test/results/clientpositive/vectorized_casts.q.out f6f210533f
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java 88e7fb00f4
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/primitive/TestPrimitiveObjectInspectorUtils.java cbf19d0389
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 13967d5186
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 2e80c9d3b1
Diff: https://reviews.apache.org/r/64282/diff/5/
Changes: https://reviews.apache.org/r/64282/diff/4-5/
Testing
-------
Thanks,
Vineet Garg
Re: Review Request 64282: HIVE-18173: Improve plans for correlated
subqueries with non-equi predicate
Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64282/
-----------------------------------------------------------
(Updated Dec. 6, 2017, 6:30 a.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------
Addressed review comments
Bugs: HIVE-18173
https://issues.apache.org/jira/browse/HIVE-18173
Repository: hive-git
Description
-------
Improve plans for correlated subqueries with non-equi predicate
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java d1fe49c875
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 76c82e2606
ql/src/test/queries/clientpositive/subquery_in.q 7d4ece9dca
ql/src/test/results/clientpositive/llap/subquery_exists.q.out dfe424046e
ql/src/test/results/clientpositive/llap/subquery_in.q.out 5dcdfdd15f
ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 0ffbaaea34
ql/src/test/results/clientpositive/llap/subquery_notin.q.out 5da12584f0
ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 6a4bea1bd4
ql/src/test/results/clientpositive/spark/subquery_exists.q.out fb13fb73e9
ql/src/test/results/clientpositive/spark/subquery_in.q.out e19240b7ca
ql/src/test/results/clientpositive/spark/subquery_multi.q.out a4282df08a
ql/src/test/results/clientpositive/spark/subquery_notin.q.out 0d12d0db60
ql/src/test/results/clientpositive/spark/subquery_scalar.q.out d8b1c92526
ql/src/test/results/clientpositive/spark/subquery_select.q.out 6feb852965
ql/src/test/results/clientpositive/spark/subquery_views.q.out 9a1c25fffd
ql/src/test/results/clientpositive/subquery_exists.q.out b6b31aaf47
ql/src/test/results/clientpositive/subquery_notexists.q.out a6175f8fec
Diff: https://reviews.apache.org/r/64282/diff/4/
Changes: https://reviews.apache.org/r/64282/diff/3-4/
Testing
-------
Thanks,
Vineet Garg
Re: Review Request 64282: HIVE-18173: Improve plans for correlated
subqueries with non-equi predicate
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64282/#review192960
-----------------------------------------------------------
ql/src/test/results/clientpositive/llap/explainuser_1.q.out
Lines 2252-2255 (original), 2252-2256 (patched)
<https://reviews.apache.org/r/64282/#comment271354>
New plan is worse then before.
ql/src/test/results/clientpositive/llap/subquery_in.q.out
Lines 441-443 (original), 441-444 (patched)
<https://reviews.apache.org/r/64282/#comment271355>
New plan is worse then before.
ql/src/test/results/clientpositive/llap/subquery_in.q.out
Lines 1521-1525 (original)
<https://reviews.apache.org/r/64282/#comment271356>
Wrong results?
ql/src/test/results/clientpositive/llap/subquery_multi.q.out
Lines 2857-2863 (original), 2857-2864 (patched)
<https://reviews.apache.org/r/64282/#comment271358>
New plan is worse then before.
ql/src/test/results/clientpositive/llap/subquery_notin.q.out
Lines 320-324 (original), 320-326 (patched)
<https://reviews.apache.org/r/64282/#comment271359>
New plan is worse then before.
ql/src/test/results/clientpositive/llap/subquery_notin.q.out
Lines 897-898 (original), 984-991 (patched)
<https://reviews.apache.org/r/64282/#comment271360>
New plan is worse then before.
ql/src/test/results/clientpositive/llap/subquery_scalar.q.out
Lines 2252-2254 (original), 2252-2256 (patched)
<https://reviews.apache.org/r/64282/#comment271361>
New plan is worse then before.
ql/src/test/results/clientpositive/llap/subquery_select.q.out
Lines 1808-1809 (original), 1808-1811 (patched)
<https://reviews.apache.org/r/64282/#comment271362>
New plan is worse then before.
ql/src/test/results/clientpositive/llap/subquery_views.q.out
Line 138 (original), 138-142 (patched)
<https://reviews.apache.org/r/64282/#comment271364>
New plan is worse then before.
ql/src/test/results/clientpositive/subquery_notin_having.q.out
Lines 230-234 (original), 230-239 (patched)
<https://reviews.apache.org/r/64282/#comment271352>
New plan is worse then before.
ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out
Lines 281-285 (original), 281-288 (patched)
<https://reviews.apache.org/r/64282/#comment271353>
New plan is worse then before.
- Ashutosh Chauhan
On Dec. 4, 2017, 10:42 p.m., Vineet Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64282/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2017, 10:42 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-18173
> https://issues.apache.org/jira/browse/HIVE-18173
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Improve plans for correlated subqueries with non-equi predicate
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java d1fe49c875
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 76c82e2606
> ql/src/test/queries/clientpositive/subquery_in.q 7d4ece9dca
> ql/src/test/results/clientpositive/llap/explainuser_1.q.out 5adf401b25
> ql/src/test/results/clientpositive/llap/subquery_exists.q.out dfe424046e
> ql/src/test/results/clientpositive/llap/subquery_in.q.out 5dcdfdd15f
> ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 0ffbaaea34
> ql/src/test/results/clientpositive/llap/subquery_multi.q.out d0a78a2bb4
> ql/src/test/results/clientpositive/llap/subquery_notin.q.out 5da12584f0
> ql/src/test/results/clientpositive/llap/subquery_scalar.q.out ab67a7dc59
> ql/src/test/results/clientpositive/llap/subquery_select.q.out d41704661d
> ql/src/test/results/clientpositive/llap/subquery_views.q.out af695691a7
> ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 6a4bea1bd4
> ql/src/test/results/clientpositive/spark/subquery_exists.q.out fb13fb73e9
> ql/src/test/results/clientpositive/spark/subquery_in.q.out e19240b7ca
> ql/src/test/results/clientpositive/spark/subquery_multi.q.out a4282df08a
> ql/src/test/results/clientpositive/spark/subquery_notin.q.out 0d12d0db60
> ql/src/test/results/clientpositive/spark/subquery_scalar.q.out d8b1c92526
> ql/src/test/results/clientpositive/spark/subquery_select.q.out 6feb852965
> ql/src/test/results/clientpositive/spark/subquery_views.q.out 9a1c25fffd
> ql/src/test/results/clientpositive/subquery_exists.q.out b6b31aaf47
> ql/src/test/results/clientpositive/subquery_notexists.q.out a6175f8fec
> ql/src/test/results/clientpositive/subquery_notin_having.q.out 433609d016
> ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out bfb5d2b0a6
>
>
> Diff: https://reviews.apache.org/r/64282/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vineet Garg
>
>
Re: Review Request 64282: HIVE-18173: Improve plans for correlated
subqueries with non-equi predicate
Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64282/
-----------------------------------------------------------
(Updated Dec. 4, 2017, 10:42 p.m.)
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-18173
https://issues.apache.org/jira/browse/HIVE-18173
Repository: hive-git
Description
-------
Improve plans for correlated subqueries with non-equi predicate
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java d1fe49c875
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 76c82e2606
ql/src/test/queries/clientpositive/subquery_in.q 7d4ece9dca
ql/src/test/results/clientpositive/llap/explainuser_1.q.out 5adf401b25
ql/src/test/results/clientpositive/llap/subquery_exists.q.out dfe424046e
ql/src/test/results/clientpositive/llap/subquery_in.q.out 5dcdfdd15f
ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 0ffbaaea34
ql/src/test/results/clientpositive/llap/subquery_multi.q.out d0a78a2bb4
ql/src/test/results/clientpositive/llap/subquery_notin.q.out 5da12584f0
ql/src/test/results/clientpositive/llap/subquery_scalar.q.out ab67a7dc59
ql/src/test/results/clientpositive/llap/subquery_select.q.out d41704661d
ql/src/test/results/clientpositive/llap/subquery_views.q.out af695691a7
ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 6a4bea1bd4
ql/src/test/results/clientpositive/spark/subquery_exists.q.out fb13fb73e9
ql/src/test/results/clientpositive/spark/subquery_in.q.out e19240b7ca
ql/src/test/results/clientpositive/spark/subquery_multi.q.out a4282df08a
ql/src/test/results/clientpositive/spark/subquery_notin.q.out 0d12d0db60
ql/src/test/results/clientpositive/spark/subquery_scalar.q.out d8b1c92526
ql/src/test/results/clientpositive/spark/subquery_select.q.out 6feb852965
ql/src/test/results/clientpositive/spark/subquery_views.q.out 9a1c25fffd
ql/src/test/results/clientpositive/subquery_exists.q.out b6b31aaf47
ql/src/test/results/clientpositive/subquery_notexists.q.out a6175f8fec
ql/src/test/results/clientpositive/subquery_notin_having.q.out 433609d016
ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out bfb5d2b0a6
Diff: https://reviews.apache.org/r/64282/diff/3/
Changes: https://reviews.apache.org/r/64282/diff/2-3/
Testing
-------
Thanks,
Vineet Garg
Re: Review Request 64282: HIVE-18173: Improve plans for correlated
subqueries with non-equi predicate
Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64282/
-----------------------------------------------------------
(Updated Dec. 3, 2017, 5:34 a.m.)
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-18173
https://issues.apache.org/jira/browse/HIVE-18173
Repository: hive-git
Description
-------
Improve plans for correlated subqueries with non-equi predicate
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java d1fe49c875
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 76c82e2606
ql/src/test/queries/clientpositive/subquery_in.q 7d4ece9dca
ql/src/test/results/clientpositive/llap/explainuser_1.q.out 5adf401b25
ql/src/test/results/clientpositive/llap/subquery_exists.q.out dfe424046e
ql/src/test/results/clientpositive/llap/subquery_in.q.out 5dcdfdd15f
ql/src/test/results/clientpositive/llap/subquery_in_having.q.out 0ffbaaea34
ql/src/test/results/clientpositive/llap/subquery_multi.q.out d0a78a2bb4
ql/src/test/results/clientpositive/llap/subquery_notin.q.out 5da12584f0
ql/src/test/results/clientpositive/llap/subquery_scalar.q.out ab67a7dc59
ql/src/test/results/clientpositive/llap/subquery_select.q.out d41704661d
ql/src/test/results/clientpositive/llap/subquery_views.q.out af695691a7
ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 6a4bea1bd4
ql/src/test/results/clientpositive/spark/subquery_exists.q.out fb13fb73e9
ql/src/test/results/clientpositive/spark/subquery_in.q.out e19240b7ca
ql/src/test/results/clientpositive/spark/subquery_multi.q.out a4282df08a
ql/src/test/results/clientpositive/spark/subquery_notin.q.out 0d12d0db60
ql/src/test/results/clientpositive/spark/subquery_scalar.q.out d8b1c92526
ql/src/test/results/clientpositive/spark/subquery_select.q.out 6feb852965
ql/src/test/results/clientpositive/spark/subquery_views.q.out 9a1c25fffd
ql/src/test/results/clientpositive/subquery_exists.q.out b6b31aaf47
ql/src/test/results/clientpositive/subquery_notexists.q.out a6175f8fec
ql/src/test/results/clientpositive/subquery_notin_having.q.out 433609d016
ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out bfb5d2b0a6
Diff: https://reviews.apache.org/r/64282/diff/2/
Changes: https://reviews.apache.org/r/64282/diff/1-2/
Testing
-------
Thanks,
Vineet Garg