You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/02 16:15:12 UTC

[GitHub] [geode] sabbey37 commented on a change in pull request #5954: GEODE-8864:finish implementation of Redis HScan Command

sabbey37 commented on a change in pull request #5954:
URL: https://github.com/apache/geode/pull/5954#discussion_r585703860



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/hash/HScanExecutor.java
##########
@@ -44,6 +45,9 @@
   @Override
   public RedisResponse executeCommand(Command command,
       ExecutionHandlerContext context) {
+
+    final UUID CLIENT_ID = context.getClientUUID();
+
     List<byte[]> commandElems = command.getProcessedCommand();

Review comment:
       I think it makes sense to leave it as an `int` given the cursor parameter will be an `int`  and max size of a hash is the same as an `int`. Thanks for discussing this with everyone!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org