You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/05/17 19:47:20 UTC

[GitHub] [orc] pgaref edited a comment on pull request #651: ORC-757: HashTable dictionary

pgaref edited a comment on pull request #651:
URL: https://github.com/apache/orc/pull/651#issuecomment-842585252


   > Gentle ping ... @pgaref
   
   Hey @autumnust thanks for pinging me, got distracted by various tasks last week!
   Also thanks for updating the benchmark, this helps a lot. Some comments:
   
   - I would expect NONE dictImpl  bench results to be identical across runs, why is 4096  X 500  run 3x the others?
   - Seems like an init size of 4k could be a good default conf in most of the cases -- would it make sense remove the extra conf completely if we can avoid it? 
   - Minor: I would rename upperBound to distinctCount
   
   Let me know what you think


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org