You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by Carsten Ziegeler <cz...@apache.org> on 2015/01/09 12:22:06 UTC

[VOTE] Release Apache Sling i18n 2.3.0

Hi,

we solved two issues
https://issues.apache.org/jira/browse/SLING/fixforversion/12327960

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1163/

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1163 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org

Re: [VOTE] Release Apache Sling i18n 2.3.0

Posted by Oliver Lietz <ap...@oliverlietz.de>.

On Monday 12 January 2015 12:34:02 Carsten Ziegeler wrote:
> Does latest trunk also fail for you?

Yes, fails.

O.

> Carsten
> 
> Am 11.01.15 um 19:31 schrieb Oliver Lietz:
> > On Friday 09 January 2015 12:22:06 Carsten Ziegeler wrote:
> >> Hi,
> >> 
> >> we solved two issues
> >> https://issues.apache.org/jira/browse/SLING/fixforversion/12327960
> > 
> > building from tag fails:
> > 
> > Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.313 sec
> > <<< FAILURE! - in org.apache.sling.i18n.impl.JcrResourceBundleTest
> > test_search_path(org.apache.sling.i18n.impl.JcrResourceBundleTest)  Time
> > elapsed: 0.098 sec  <<< FAILURE! junit.framework.ComparisonFailure:
> > expected:<[OTHER]> but was:<[K�che]>> 
> > 	at junit.framework.Assert.assertEquals(Assert.java:100)
> > 	at junit.framework.Assert.assertEquals(Assert.java:107)
> > 	at junit.framework.TestCase.assertEquals(TestCase.java:269)
> > 	at
> > 	org.apache.sling.i18n.impl.JcrResourceBundleTest.test_search_path(JcrRes
> > 	ourceBundleTest.java:539)> 
> > Running org.apache.sling.i18n.impl.RootResourceBundleTest
> > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in
> > org.apache.sling.i18n.impl.RootResourceBundleTest
> > 
> > Results :
> > 
> > Failed tests:
> >   JcrResourceBundleTest.test_search_path:539 expected:<[OTHER]> but
> >   was:<[K�che]>> 
> > Tests run: 16, Failures: 1, Errors: 0, Skipped: 0
> > 
> > [INFO]
> > ------------------------------------------------------------------------
> > [INFO] BUILD FAILURE
> > [INFO]
> > ------------------------------------------------------------------------
> > 
> > 2.2.6 is the last version which builds without this failure.
> > 
> > O.

Re: [VOTE] Release Apache Sling i18n 2.3.0

Posted by Carsten Ziegeler <cz...@apache.org>.

Does latest trunk also fail for you?

Carsten

Am 11.01.15 um 19:31 schrieb Oliver Lietz:
> On Friday 09 January 2015 12:22:06 Carsten Ziegeler wrote:
>> Hi,
>>
>> we solved two issues
>> https://issues.apache.org/jira/browse/SLING/fixforversion/12327960
> 
> building from tag fails:
> 
> Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.313 sec <<< FAILURE! - in org.apache.sling.i18n.impl.JcrResourceBundleTest
> test_search_path(org.apache.sling.i18n.impl.JcrResourceBundleTest)  Time elapsed: 0.098 sec  <<< FAILURE!
> junit.framework.ComparisonFailure: expected:<[OTHER]> but was:<[K�che]>
> 	at junit.framework.Assert.assertEquals(Assert.java:100)
> 	at junit.framework.Assert.assertEquals(Assert.java:107)
> 	at junit.framework.TestCase.assertEquals(TestCase.java:269)
> 	at org.apache.sling.i18n.impl.JcrResourceBundleTest.test_search_path(JcrResourceBundleTest.java:539)
> 
> Running org.apache.sling.i18n.impl.RootResourceBundleTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.apache.sling.i18n.impl.RootResourceBundleTest
> 
> Results :
> 
> Failed tests: 
>   JcrResourceBundleTest.test_search_path:539 expected:<[OTHER]> but was:<[K�che]>
> 
> Tests run: 16, Failures: 1, Errors: 0, Skipped: 0
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> 
> 2.2.6 is the last version which builds without this failure.
> 
> O.
> 
> 


-- 
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org

Re: [VOTE] Release Apache Sling i18n 2.3.0

Posted by Carsten Ziegeler <cz...@apache.org>.

Am 12.01.15 um 16:12 schrieb Bertrand Delacretaz:
> On Mon, Jan 12, 2015 at 4:09 PM, Carsten Ziegeler <cz...@apache.org> wrote:
>> ...I think the test is wrong, the impl shouldn't be required to use an
>> ordered set (unless I'm overlooking something)....
> 
> I haven't looked at all the details but it seemed like the ordering is
> used to give precedence to messages under /apps over those under
> /libs. The wrong ordering caused the test to fail.
> 
So how do you know that apps is in the set before libs? What if have
resource resolver configured with /zoo which comes before /apps in the
search path?

Right now a search is done over the whole repository and the result is
put into a set, so if we need a different ordering, than we need to sort
the result accordingly.

Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org

Re: [VOTE] Release Apache Sling i18n 2.3.0

Posted by Bertrand Delacretaz <bd...@apache.org>.

On Mon, Jan 12, 2015 at 4:09 PM, Carsten Ziegeler <cz...@apache.org> wrote:
> ...I think the test is wrong, the impl shouldn't be required to use an
> ordered set (unless I'm overlooking something)....

I haven't looked at all the details but it seemed like the ordering is
used to give precedence to messages under /apps over those under
/libs. The wrong ordering caused the test to fail.

-Bertrand

Re: [VOTE] Release Apache Sling i18n 2.3.0

Posted by Carsten Ziegeler <cz...@apache.org>.

Am 12.01.15 um 16:03 schrieb Bertrand Delacretaz:
> On Mon, Jan 12, 2015 at 3:34 PM, Robert Munteanu <ro...@apache.org> wrote:
>> ...Without looking at the test, I think it's relying on the ordering
>> maintained by a HashSet, which has changed with Java 8, and is of
>> course nothing to rely on...
> 
> It's something like that but in the actual code, not in the test -
> looking at it under SLING-4299
> 

I think the test is wrong, the impl shouldn't be required to use an
ordered set (unless I'm overlooking something).

Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org

Re: [VOTE] Release Apache Sling i18n 2.3.0

Posted by Bertrand Delacretaz <bd...@apache.org>.

On Mon, Jan 12, 2015 at 3:34 PM, Robert Munteanu <ro...@apache.org> wrote:
> ...Without looking at the test, I think it's relying on the ordering
> maintained by a HashSet, which has changed with Java 8, and is of
> course nothing to rely on...

It's something like that but in the actual code, not in the test -
looking at it under SLING-4299

-Bertrand

Re: [VOTE] Release Apache Sling i18n 2.3.0

Posted by Robert Munteanu <ro...@apache.org>.

On Mon, Jan 12, 2015 at 4:32 PM, Bertrand Delacretaz
<bd...@apache.org> wrote:
> On Sun, Jan 11, 2015 at 7:31 PM, Oliver Lietz <ap...@oliverlietz.de> wrote:
>> ...Failed tests:
>>   JcrResourceBundleTest.test_search_path:539 expected:<[OTHER]> but was:<[K�che]>
>
> I get the same failure with Java 8, but with Java 7 the test passes.

Without looking at the test, I think it's relying on the ordering
maintained by a HashSet, which has changed with Java 8, and is of
course nothing to rely on . I fixed a couple of such issues for the
sling-trunk-1.8 build.

Robert

Re: [VOTE] Release Apache Sling i18n 2.3.0

Posted by Bertrand Delacretaz <bd...@apache.org>.

On Sun, Jan 11, 2015 at 7:31 PM, Oliver Lietz <ap...@oliverlietz.de> wrote:
> ...Failed tests:
>   JcrResourceBundleTest.test_search_path:539 expected:<[OTHER]> but was:<[K�che]>

I get the same failure with Java 8, but with Java 7 the test passes.

-Bertrand

Re: [VOTE] Release Apache Sling i18n 2.3.0

Posted by Oliver Lietz <ap...@oliverlietz.de>.

On Friday 09 January 2015 12:22:06 Carsten Ziegeler wrote:
> Hi,
> 
> we solved two issues
> https://issues.apache.org/jira/browse/SLING/fixforversion/12327960

building from tag fails:

Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.313 sec <<< FAILURE! - in org.apache.sling.i18n.impl.JcrResourceBundleTest
test_search_path(org.apache.sling.i18n.impl.JcrResourceBundleTest)  Time elapsed: 0.098 sec  <<< FAILURE!
junit.framework.ComparisonFailure: expected:<[OTHER]> but was:<[K�che]>
	at junit.framework.Assert.assertEquals(Assert.java:100)
	at junit.framework.Assert.assertEquals(Assert.java:107)
	at junit.framework.TestCase.assertEquals(TestCase.java:269)
	at org.apache.sling.i18n.impl.JcrResourceBundleTest.test_search_path(JcrResourceBundleTest.java:539)

Running org.apache.sling.i18n.impl.RootResourceBundleTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.apache.sling.i18n.impl.RootResourceBundleTest

Results :

Failed tests: 
  JcrResourceBundleTest.test_search_path:539 expected:<[OTHER]> but was:<[K�che]>

Tests run: 16, Failures: 1, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

2.2.6 is the last version which builds without this failure.

O.