[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5538: In ServerQueryRequest and ColumnValueSegmentPruner, replace BrokerRequest with QueryContext

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #5538:
URL: https://github.com/apache/incubator-pinot/pull/5538#discussion_r440499510



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
##########
@@ -205,8 +205,9 @@ public DataTable processQuery(ServerQueryRequest queryRequest, ExecutorService e
         metadata.put(DataTable.NUM_SEGMENTS_MATCHED, "0");
       } else {
         TimerContext.Timer planBuildTimer = timerContext.startNewPhaseTimer(ServerQueryPhase.BUILD_QUERY_PLAN);
-        Plan globalQueryPlan =
-            _planMaker.makeInterSegmentPlan(segmentDataManagers, brokerRequest, executorService, remainingTimeMs);
+        Plan globalQueryPlan = _planMaker
+            .makeInterSegmentPlan(segmentDataManagers, queryContext.getBrokerRequest(), executorService,
+                remainingTimeMs);

Review comment:
       @siddharthteotia Yes. I'll replace BrokerRequest with QueryContext step by step so that each PR won't be too big. Replacing BrokerRequest with QueryContext in `PlanNode` will be next step.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org